Skip to content

Conversation

@muXxer
Copy link
Contributor

@muXxer muXxer commented Nov 11, 2024

Description of change

This PR adds the computation_cost_burned to more parts in the code, and it also adds safe_mode_computation_rewards_burned to the system state.

It might need to be included in #3517, and the types should be properly versioned in case they are breaking.

Links to any relevant issues

Continuation of #3944

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@muXxer muXxer added the node Issues related to the Core Node team label Nov 11, 2024
@muXxer
Copy link
Contributor Author

muXxer commented Feb 5, 2025

It seems all the changes are already included in #3517, so I will close this one.

@muXxer muXxer closed this Feb 5, 2025
@alexsporn alexsporn deleted the core-node/feat/add-computation-costs-burned branch February 5, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-protocol node Issues related to the Core Node team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants