Skip to content

feat(protocol): PCR-2 fixed base fee #3517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 108 commits into from
Closed

feat(protocol): PCR-2 fixed base fee #3517

wants to merge 108 commits into from

Conversation

@cyberphysic4l
Copy link
Contributor

@cyberphysic4l cyberphysic4l commented Oct 21, 2024 •
edited
Loading

DEPRECATED

See #5270 for base changes associated with this PR, and supporting PCR-2 PRs

@alexsporn alexsporn added the tokenomics Issues related to tokenomics and gas price modulation label Oct 22, 2024
@begonaalvarezd begonaalvarezd mentioned this pull request Oct 22, 2024
Closed
vekkiokonio
vekkiokonio reviewed Oct 24, 2024
View reviewed changes
@vekkiokonio vekkiokonio mentioned this pull request Oct 24, 2024
Closed
@vekkiokonio vekkiokonio linked an issue Oct 25, 2024 that may be closed by this pull request
[Task (gas-price-modulation-tf)] Implement a fixed protocol-based gas price #3122
Closed
@muXxer muXxer mentioned this pull request Nov 11, 2024
Closed
6 tasks
cyberphysic4l
cyberphysic4l commented Nov 14, 2024
View reviewed changes
@github-actions github-actions bot added documentation Improvements or additions to documentation apps-ui-kit Issues related to the Apps UI Kit wallet Issues related to the IOTA Wallet explorer Issues related to the Explorer wallet-dashboard Issues related to the Wallet Dashboard dApp labels Feb 4, 2025
@alexsporn alexsporn force-pushed the core-protocol/procotol-version-4 branch from 67e9904 to d0890a4 Compare February 5, 2025 10:37
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025 •
edited
Loading

⚠️ 🦋 Changesets Warning: This PR has changes to public npm packages, but does not contain a changeset. You can create a changeset easily by running pnpm changeset in the root of the IOTA repo, and following the prompts. If your change does not need a changeset (e.g. a documentation-only change), you can ignore this message. This warning will be removed when a changeset is added to this pull request.

Learn more about Changesets.

muXxer
muXxer requested changes Feb 5, 2025
View reviewed changes
crates/iota-indexer/migrations/pg/2023-08-19-044044_checkpoints/up.sql
timestamp_ms BIGINT NOT NULL,
total_gas_cost BIGINT NOT NULL,
computation_cost BIGINT NOT NULL,
computation_cost_burned BIGINT NOT NULL,
Copy link
Contributor

@muXxer muXxer Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree.

I wonder if all these migration files are actually needed, because we started with a much cleaner state anyway from the beginning.

For this PR we need a new migration file I guess.

crates/iota-graphql-rpc/src/types/transaction_block_kind/end_of_epoch.rs
#[derive(Union, Clone, PartialEq, Eq)]
pub(crate) enum EndOfEpochTransactionKind {
ChangeEpoch(ChangeEpochTransaction),
ChangeEpochV2(ChangeEpochTransactionV2),
Copy link
Contributor

@muXxer muXxer Feb 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question about the position in the enum here.

crates/iota-json-rpc-types/src/iota_transaction.rs
#[derive(Debug, Clone, Serialize, Deserialize, JsonSchema, PartialEq, Eq)]
pub enum IotaEndOfEpochTransactionKind {
ChangeEpoch(IotaChangeEpoch),
ChangeEpochV2(IotaChangeEpochV2),
Copy link
Contributor

@muXxer muXxer Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question here about the enum position.

@vekkiokonio vekkiokonio mentioned this pull request Feb 7, 2025
Merged
6 tasks
@gokhan-simsek-iota gokhan-simsek-iota mentioned this pull request Feb 7, 2025
Closed
5 tasks
@alexsporn alexsporn deleted the protocol/pcr2 branch March 4, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@valeriyr valeriyr valeriyr requested changes

@vekkiokonio vekkiokonio vekkiokonio left review comments

@alexsporn alexsporn alexsporn left review comments

@DaughterOfMars DaughterOfMars DaughterOfMars left review comments

@miker83z miker83z miker83z requested changes

@muXxer muXxer muXxer approved these changes

@kodemartin kodemartin Awaiting requested review from kodemartin

@luca-moser luca-moser Awaiting requested review from luca-moser

@lzpap lzpap Awaiting requested review from lzpap

@msarcev msarcev Awaiting requested review from msarcev

@thibault-martinez thibault-martinez Awaiting requested review from thibault-martinez

@Dr-Electron Dr-Electron Awaiting requested review from Dr-Electron

+1 more reviewer

@gokhan-simsek-iota gokhan-simsek-iota gokhan-simsek-iota left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@vekkiokonio vekkiokonio

@cyberphysic4l cyberphysic4l

Labels

apps-ui-kit Issues related to the Apps UI Kit core-protocol documentation Improvements or additions to documentation explorer Issues related to the Explorer research tokenomics Issues related to tokenomics and gas price modulation ts-sdk Issues related to the TS SDK wallet Issues related to the IOTA Wallet wallet-dashboard Issues related to the Wallet Dashboard dApp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Burned token amount confusing in SystemEpochInfoEventV1 [Task (gas-price-modulation-tf)] Implement a fixed protocol-based gas price