feat(ffi): Add FFI types for Bls12381 #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thoralf-M
approved these changes
Aug 26, 2025
| pub struct ValidatorAggregatedSignature(pub iota_types::ValidatorAggregatedSignature); | ||
|
|
||
| #[uniffi::export] | ||
| impl ValidatorAggregatedSignature { |
Member
There was a problem hiding this comment.
No need for a bitmap getter?
Contributor
Author
There was a problem hiding this comment.
I wasn't really sure how to handle it. I could just serialize the bytes for the getter but I can't just return the type.
Member
There was a problem hiding this comment.
I'm kind of lacking the context if it's useful to get it or not, in doubt I'd serialise it yeah
thibault-martinez
approved these changes
Aug 26, 2025
This was referenced Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds FFI for Bls12381 types.
Closes #136