WIP: Remove parser, port C# Task, and other modernisation#30
WIP: Remove parser, port C# Task, and other modernisation#30baronfel merged 25 commits intoionide:mainfrom
Conversation
|
Oh, and I know 17 mentions making it C# deliberately: I figure we can always swap back if the repo gets closer to a model example with all the other best practice changes made :) |
baronfel
left a comment
There was a problem hiding this comment.
Left a number of comments - this is all great work! The big question to me is what is the layout of the generated nupkg from this set of changes, and how does it compare to previous versions?
Swap to license expression Enable source link repo url
|
@baronfel I believe I've addressed all the current comments. One outstanding question I have: |
|
we should totally move to .NET 8 as part of this |
|
Enhancement that would make the diffs easier: If you add |
|
I'll re-apply your deduplication of the build props/target files as well |
baronfel
left a comment
There was a problem hiding this comment.
This looks lovely - thank you for doing this. Do you have any final concerns? It all looks solid to me.
I think this is good as a first set: I'll look at improving the tests in the next PR! |
|
Ironically, I didn't update the CHANGELOG.md |
|
@baronfel could you publish a new NuGet? Maybe prerelease? Users of my libraries (that have this task) also reported the „Fparsec bug“ |
|
@tpetricek @Krzysztof-Cieslak @nojaf @baronfel I am not sure who maintains this repo. Since this PR is merged, could any of you publish a new nuget ? |
|
I don't have any permissions here, I believe only @baronfel does. |
|
Sorry about that. I pushed 0.3.0 today. |
|
Thanks @TheAngryByrd . Similar to #37, I also had a few CI builds fail. |


WHAT
This combines #17 and https://github.com/MangelMaxime/KeepAChangelog/tree/feature/rework
It removes the parser library, replacing it with an F# port of #17's C# implementation.
It adds the tests from @MangelMaxime 's work, as well as porting the test from #17.
It makes the general build changes from @MangelMaxime 's work, including central package management, and package lock. These are slightly amended to fix a few issues/redundant bits.
This now works in Visual studio, for both C# and F# SDK projects, for both net472 and net6/8.
WHAT NOT
This doesn't (yet) have enough tests.
This doesn't actually make any improvements to the features of the task.
WHY
I wanted to work on an msbuild task, and @MangelMaxime suggested this one.
If this is reasonable as an approach, I'd like to start adding some of the low hanging fruit in issues.