WIP: Remove custom parser in favor of another package#17
Closed
WIP: Remove custom parser in favor of another package#17
Conversation
Contributor
Author
6a893ff to
514fc04
Compare
Contributor
Author
|
Rainer helped me figure out what was going on:
This same property also results in deps.json files being generated, so we should just simplify to that property. It's pretty cool that with that property, there's no difference in targeting Full framework vs .NET MSBuild, from a packaging perspective. Really sweet stuff. The package itself needs testing (which I'll do manually now that the package is valid), but we're almost ready to merge this. |
|
Any plan to merge this PR? I am facing below issue on VisualStudio 2022, but use dotnet cli is working as expected. I think this PR may solve my issue. |
Closed
Contributor
Author
|
Closing as @tboby has superseded this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR
I did this because
Current problems:
ResolveReferencestarget doesn't run when I expect and so noBuildOutputInPackageitems are written for thenet6.0TFM. This results in the following incorrect package layout: