Fix( popover-arrow ): render above backdrop #28430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
added a commit
that referenced
this pull request
Nov 28, 2023
I noticed that Dependabot PRs never had anyone assigned: #28586 The reason was that we removed `* @ionic-team/framework` when we adjusted the codeowners in #27573. My original reasoning for why we should remove it was wrong. GitHub only assigns reviewers within a team if the team itself is assigned. By removing the team from being reviewed, only people listed in the codeowners file would be assigned. As an added example, PRs that do not match codeowners currently have no one assigned: #28430
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
I noticed that Dependabot PRs never had anyone assigned: #28586 The reason was that we removed `* @ionic-team/framework` when we adjusted the codeowners in #27573. My original reasoning for why we should remove it was wrong. GitHub only assigns reviewers within a team if the team itself is assigned. By removing the team from being reviewed, only people listed in the codeowners file would be assigned. As an added example, PRs that do not match codeowners currently have no one assigned: #28430
|
Thank you for submitting the PR! After reviewing, I noticed that the issue is only happening within the Ionic docs site. Closing the PR since the issue is occurring in the Ionic docs repo. You are welcome to open a new PR that fixes the issue over at the Ionic docs repo. |
|
After discussing with the team, the issue indeed lies within the Ionic Framework. |
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
Issue number: resolves #28985 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> When a popover is being rendered in iOS mode, the arrow renders under the backdrop.  ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - The arrow renders at the same level as the content.  ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Credit [Sahil-B07](https://github.com/Sahil-B07) for providing the [fix](#28430). A new PR had to be created in order to update snapshots. --------- Co-authored-by: Sahil Bhor <[email protected]> --------- Co-authored-by: ionitron <[email protected]>
liamdebeasi
pushed a commit
that referenced
this pull request
Feb 7, 2024
Issue number: resolves #28985 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> <!-- Please describe the current behavior that you are modifying. --> When a popover is being rendered in iOS mode, the arrow renders under the backdrop.  <!-- Please describe the behavior or changes that are being added by this PR. --> - The arrow renders at the same level as the content.  - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer for more information. --> <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Credit [Sahil-B07](https://github.com/Sahil-B07) for providing the [fix](#28430). A new PR had to be created in order to update snapshots. --------- Co-authored-by: Sahil Bhor <[email protected]> Co-authored-by: ionitron <[email protected]>
|
Closing this PR since the issue was fixed in another PR. We had to open another PR in order to update screenshots. No worries, though! You were given co author credit. Thank you for solving the issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #28985
fixes: #28985
What is the current behavior?
when the popover is presented in iOS the arrow is lighter than the popover container as a result of rendering under the backdrop.
What is the new behavior?
Now the arrow is visible and is rendering above/in-Front-of backdrop.
