Skip to content

Commit

Permalink
chore: fallback to framework team with codeowners
Browse files Browse the repository at this point in the history
I noticed that Dependabot PRs never had anyone assigned: #28586

The reason was that we removed `* @ionic-team/framework` when we adjusted the codeowners in #27573. 

My original reasoning for why we should remove it was wrong. GitHub only assigns reviewers within a team if the team itself is assigned. By removing the team from being reviewed, only people listed in the codeowners file would be assigned. As an added example, PRs that do not match codeowners currently have no one assigned: #28430
  • Loading branch information
liamdebeasi authored Nov 28, 2023
1 parent 01130e1 commit c767914
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
# In each subsection folders are ordered first by depth, then alphabetically.
# This should make it easy to add new rules without breaking existing ones.

* @ionic-team/framework

# Frameworks

## Angular
Expand Down

0 comments on commit c767914

Please sign in to comment.