Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

Provide the PathLocationStrategy in development mode #1339

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

StefanRein
Copy link
Contributor

Short description of what this resolves:

With --pathlocationstrategy e.g. npm run ionic-app-scripts serve --pathlocationstrategy you can now use the PathLocationStrategy. This means you can refresh on a route like this: http://localhost:8100/dashboard/my-feature without a server error and loading the correct view of the route without the need to open http://localhost:8100/#/dashboard/my-feature with the HashLocationStrategy.

Changes proposed in this pull request:

  • Add a command line flag for enabling the PathLocationStrategy in development mode.
  • If this flag is enabled, reroute any requests to serveIndex => e.g. index.html

Fixes: #10565

@StefanRein
Copy link
Contributor Author

Also fixes this on local development: ionic-team/ionic-framework#10565

@StefanRein
Copy link
Contributor Author

@danbucholtz

@StefanRein
Copy link
Contributor Author

StefanRein commented Dec 14, 2017

Ok discovered a resulting bug:

He can not load: ion-dev.js and the ion-dev.css

I'll look into this and commit a fix.

@StefanRein
Copy link
Contributor Author

Just needed to inject the dev logger script absolute now.

@StefanRein
Copy link
Contributor Author

StefanRein commented Dec 15, 2017

I did experience an issue with <base href="/">.
Additionally it will be broken on a document.location.reload() call, because the running server in app does not reroute to index.html.

@Kawzeg
Copy link

Kawzeg commented Feb 25, 2019

This breaks proxies, because setupProxies sets up the proxies asynchronously.

@arimus
Copy link

arimus commented May 29, 2019

So...any word on a fix / new merge for path location support? Or is there any way to resolve that doesn't involve manually editing node_modules files?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants