Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

Please merge PR to support path-based location strategy in local dev "ionic serve" #974

Open
lincolnthree opened this issue May 9, 2017 · 2 comments

Comments

@lincolnthree
Copy link

Note: for support questions, please use one of these channels:

https://forum.ionicframework.com/
http://ionicworldwide.herokuapp.com/

Short description of the problem:

When using path based location strategy (not hash), path based routing results in 404s when dynamic reloading occurs after making any code changes during development.

What behavior are you expecting?

This:

#916

Steps to reproduce:

  1. Use path-based routing
  2. Navigate to a deep-link
  3. Make a code change, webpack hot-reload fails with 404
insert any relevant code between the above and below backticks

Which @ionic/app-scripts version are you using?
1.3.7

Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)
This pull request fixes the issue quite nicely.

#916

@lincolnthree lincolnthree changed the title Please support path-based location strategy in local dev "ionic serve" Please merge PR to support path-based location strategy in local dev "ionic serve" May 9, 2017
@jayvdb
Copy link

jayvdb commented Dec 19, 2018

It was merged, and revert in 065912e because it was placed before the proxies (and thus broke them) , and #1339 is the current PR.

@Kawzeg
Copy link

Kawzeg commented Feb 25, 2019

Placing it after setupProxies(app) is not enough, because the proxies are setup asynchronously.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants