Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

TSLint: add ability to exclude files and folders #1204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

datencia
Copy link

@datencia datencia commented Sep 1, 2017

Short description of what this resolves:

After upgrade to Ionic 3, tslint shows errors even for external typescript libraries inside the node_modules folder.

Changes proposed in this pull request:

  • Change envVar option value to upper case (ionic_tslint -> IONIC_TSLINT) (as the rest of functionalities)
  • Change packageConfig option value to lower case (IONIC_TSLINT -> ionic_tslint) according to the docs Overriding Config Files
  • Add ability to override config file for linter (actually, the package config setting is only used to specify the tslint.json to be used. Now allows you to:
    • Exclude files and folders from the linter by setting glob patterns
    • Specify the tslint.json file that is used.

Fixes: #1203

@yannbf
Copy link

yannbf commented Oct 25, 2017

Looking forward to this getting merged! I'm having issues and this blocks the usage of a few pre-commit hooks in our project.

Could @danbucholtz take a look? It's been two months :s

@MattiLehtinen
Copy link

Would appreciate this!

@miquelferrerllompart
Copy link

Would appreciate this too!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants