Skip to content
This repository has been archived by the owner on May 1, 2020. It is now read-only.

Exclude node_modules folder from tslint #1203

Open
datencia opened this issue Sep 1, 2017 · 0 comments
Open

Exclude node_modules folder from tslint #1203

datencia opened this issue Sep 1, 2017 · 0 comments

Comments

@datencia
Copy link

datencia commented Sep 1, 2017

Short description of the problem:

After upgrade to Ionic 3, tslint shows errors even for external typescript libraries inside the node_modules folder.

What behavior are you expecting?

tslint should lint files under src folder only.

Steps to reproduce:

  1. create an empty ionic project

    $ ionic start demo-app blank
  2. install a dependency which includes the typescript files (e.g. ng2-dynamic-forms/core)

    $ npm install @ng2-dynamic-forms/core
  3. import the module into the app module (modify the app.module.ts as follows):

    ...
    import { DynamicFormsCoreModule } from '@ng2-dynamic-forms/core';
    
    @NgModule({
      declarations: [
        MyApp,
        HomePage
      ],
      imports: [
        BrowserModule,
        DynamicFormsCoreModule.forRoot(),
        IonicModule.forRoot(MyApp)
      ],
      ...
    
  4. run the linter

    $ npm run lint

image

Which @ionic/app-scripts version are you using?

2.1.4

Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)

related issues: #482 & #161

@datencia datencia changed the title Exclude node_folder from tslint Exclude node_modules folder from tslint Jan 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant