Skip to content

[sdk-sync] Sync with copilot-sdk: ignore cliPath when cliUrl is set #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kawax merged 1 commit into from
Mar 11, 2026
Merged

[sdk-sync] Sync with copilot-sdk: ignore cliPath when cliUrl is set #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion copilot-sdk
Open in desktop
Submodule copilot-sdk updated 3 files
+80 −231 .github/workflows/cross-repo-issue-analysis.lock.yml
+12 −2 nodejs/src/client.ts
+9 −0 nodejs/test/client.test.ts
8 changes: 7 additions & 1 deletion src/Process/ProcessManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,13 @@ public function getStdioTransport(): StdioTransport
protected function startProcess(): void
{
if (empty($this->cliPath)) {
$this->cliPath = (new ExecutableFinder)->find(name: 'copilot', default: 'copilot');
$this->cliPath = (new ExecutableFinder)->find(name: 'copilot');
}

if (empty($this->cliPath)) {
throw new RuntimeException(
'Path to Copilot CLI is required. Please provide it via the cli_path option, or use cli_url to rely on a remote CLI.',
);
}

// Handle 'gh copilot' case
Expand Down