Conversation
When cli_url is provided, cliPath should not be resolved. The Laravel SDK already handles this correctly via TCP mode, but now ProcessManager throws a descriptive error when the CLI binary cannot be found, matching the official SDK behavior. Official SDK: ab8cc5a [nodejs] Ignore `cliPath` if `cliUrl` is set (#787) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Official SDK Changes
Syncing official
github/copilot-sdkcommits27f487f..062b61c:ab8cc5a— [nodejs] IgnorecliPathifcliUrlis set (#787)062b61c— Update cross-repo-issue-analysis.lock.yml (CI only)Compare: https://github.com/github/copilot-sdk/compare/27f487f9a65b7b39dbb96d0a13fbedc9c65cbcb1..062b61c8aa63b9b5d45fa1d7b01723e6660ffa83
Summary of Changes
The official SDK now explicitly sets
cliPath = undefinedwhencliUrlis provided, preventing the bundled CLI path from being resolved unnecessarily. It also adds a guard that throws a descriptive error ifcliPathis missing when trying to start the stdio process.The Laravel SDK already handles this correctly via TCP mode separation (when
cli_urlis set,ProcessManageris never instantiated). The alignment needed was inProcessManager::startProcess():ExecutableFinderwithdefault: 'copilot', which would silently fall back to the string'copilot'even when the binary doesn't exist, causing a less informative error later duringproc_openExecutableFinderwithout a default, then throws a clearRuntimeExceptionif no CLI binary is found — matching the official SDK's error message patternLaravel Files Modified
copilot-sdk062b61csrc/Process/ProcessManager.phpBreaking Changes
None. The error message is now more descriptive, but the only behavior change is when
copilotbinary is not found — previously this would fail later duringproc_open, now it fails earlier with a clearer message.