Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global: invenio.config deprecation #3106

Closed
hachreak opened this issue May 7, 2015 · 2 comments
Closed

global: invenio.config deprecation #3106

hachreak opened this issue May 7, 2015 · 2 comments
Assignees
@hachreak
Milestone
v2.2.0

Comments

@hachreak
Copy link
Member

hachreak commented May 7, 2015

@jirikuncar told me that it's there only for legacy code and should be deprecated.
But if you execute git grep "invenio.config", you can see that also many "normal" modules use it.

Can we deprecate it and substitute all invenio.config with invenio.base.config?
@jirikuncar
Copy link
Member

Can we deprecate it and substitute all invenio.config with invenio.base.config?

We can deprecate it but we should not replace it with invenio.base.config but with invenio.base.globals:cfg or current_app.config. Please note that we should do it only in invenio.modules as invenio.legacy requires UTF-8 values.

You can add warning that it will be removed in 2.3.

@jirikuncar jirikuncar added the RFC label May 7, 2015
@jirikuncar jirikuncar added this to the v2.1.0 milestone May 7, 2015
hachreak pushed a commit to hachreak/invenio that referenced this issue May 7, 2015
global: invenio.config deprecation
b91577b 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (closes inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 8, 2015
global: invenio.config deprecation
4be9f1f 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (closes inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 8, 2015
global: invenio.config deprecation
c76cdba 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (closes inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 8, 2015
global: invenio.config deprecation
450f276 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (closes inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 8, 2015
global: invenio.config deprecation
7d5b302 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (closes inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 8, 2015
global: invenio.config deprecation
67ebb38 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (closes inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 8, 2015
global: invenio.config deprecation
f1b2a06 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (closes inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 8, 2015
global: url_for unicode compatibility fix
e328dfd 
* INCOMPATIBLE Changes url_for behaviour to return always a unicode
  string. (addresses inveniosoftware#2967)

* INCOMPATIBLE Deprecates invenio.config hack for legacy code.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
Reviewed-by: Jiri Kuncar <[email protected]>
@hachreak hachreak mentioned this issue May 8, 2015
Merged
@jirikuncar jirikuncar modified the milestones: v2.2.0, v2.1.0 May 8, 2015
hachreak pushed a commit to hachreak/invenio that referenced this issue May 11, 2015
global: invenio.config deprecation
dfc687c 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
@hachreak hachreak mentioned this issue May 11, 2015
Closed
hachreak pushed a commit to hachreak/invenio that referenced this issue May 11, 2015
global: invenio.config deprecation
da3676e 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 12, 2015
global: invenio.config deprecation
ec65930 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 12, 2015
formatter: invenio.config deprecation
030edf1 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 12, 2015
bulletin: invenio.config deprecation
e83b3ce 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 12, 2015
search: invenio.config deprecation
aeae834 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 12, 2015
global: invenio.config deprecation
2b4f7a9 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 12, 2015
formatter: invenio.config deprecation
1821e89 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 12, 2015
bulletin: invenio.config deprecation
c409b4b 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 12, 2015
search: invenio.config deprecation
32a7b03 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 12, 2015
global: invenio.config deprecation
958c570 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 12, 2015
formatter: invenio.config deprecation
2837858 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 12, 2015
bulletin: invenio.config deprecation
47ce844 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 12, 2015
search: invenio.config deprecation
9033e3a 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Jul 23, 2015
scheduler: invenio.config deprecation
cae637a 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Jul 23, 2015
encoder: invenio.config deprecation
a3f2bc1 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Jul 23, 2015
oauthclient: invenio.config deprecation
50ea81c 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Jul 23, 2015
redirector: invenio.config deprecation
4fd8e42 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Jul 23, 2015
upgrader: invenio.config deprecation
8177b02 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Jul 23, 2015
workflows: fix configuration loading
ddcf37d 
* Replace direct import of invenio.base.config with
  invenio.base.globals:cfg. (addresses inveniosoftware#3106)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Jul 23, 2015
encoder: invenio.config deprecation
8a81139 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Jul 23, 2015
global: invenio.config deprecation
7f67d51 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Jul 23, 2015
formatter: invenio.config deprecation
e98f72d 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Jul 23, 2015
scheduler: invenio.config deprecation
bfc3646 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Jul 23, 2015
encoder: invenio.config deprecation
f2aae85 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Jul 23, 2015
oauthclient: invenio.config deprecation
bdb2b82 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Jul 23, 2015
redirector: invenio.config deprecation
b5d4bc4 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Jul 23, 2015
upgrader: invenio.config deprecation
48c9388 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Jul 23, 2015
workflows: fix configuration loading
d4e4a6a 
* Replace direct import of invenio.base.config with
  invenio.base.globals:cfg. (addresses inveniosoftware#3106)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Jul 23, 2015
encoder: invenio.config deprecation
d4b6dec 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Jul 23, 2015
encoder: invenio.config deprecation
d2f5863 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Jul 23, 2015
global: invenio.config deprecation
8de2ad7 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Jul 23, 2015
formatter: invenio.config deprecation
f83ae6a 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Jul 23, 2015
scheduler: invenio.config deprecation
294bdf9 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Jul 23, 2015
encoder: invenio.config deprecation
6241def 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Jul 23, 2015
oauthclient: invenio.config deprecation
8d5eda1 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Jul 23, 2015
redirector: invenio.config deprecation
9b9ecca 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Jul 23, 2015
upgrader: invenio.config deprecation
3cd30c4 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Jul 23, 2015
workflows: fix configuration loading
a02d432 
* Replace direct import of invenio.base.config with
  invenio.base.globals:cfg. (addresses inveniosoftware#3106)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Jul 23, 2015
encoder: invenio.config deprecation
fe7616b 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Sep 4, 2015
global: invenio.config deprecation
e7a2729 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Sep 4, 2015
scheduler: invenio.config deprecation
4c96946 
* Replaces usage of invenio.config with invenio.base.globals:cfg.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
@jirikuncar
Copy link
Member

Invenio 3 modules are using standard Flask configuration (current_app.config). Additional configuration loading has been moved to Invenio-Config package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hachreak hachreak

Labels
None yet
Projects
None yet
Milestone
v2.2.0
Development

No branches or pull requests
2 participants
@jirikuncar @hachreak