Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: investigate loud warnings and errors #2967

Closed
2 of 11 tasks
hachreak opened this issue Mar 30, 2015 · 3 comments
Closed
2 of 11 tasks

tests: investigate loud warnings and errors #2967

hachreak opened this issue Mar 30, 2015 · 3 comments
Assignees
Milestone

Comments

@hachreak
Copy link
Member

I executed tests in local and I received many warning and errors.
It's a summary:

  • WARNING:py.warnings: /path/to/file.html RuntimeWarning: Convert string 'active' in template to unicode..
  • InvenioBibFormatError: Format element SERVER_INFO could not be found.
  • ERROR:invenio.base:Error retrieving the blob for recid 33
  • AttributeError: 'NoneType' object has no attribute 'legacy_create_recstruct'
  • AttributeError: 'NoneType' object has no attribute 'creation_date'
  • KeyError: 'Default_unknown.bft'
  • ImportError: import_string() failed for 'invenio.legacy.webcomment.webinterface'.. See also search: remove legacy webinterface #2958 (closed by global: access errors import fix #2973)
  • WorkflowError: WorkflowError(Error: ZeroDivisionError()
  • ImportError: cannot import name InvenioWebAccessMailCookieDeletedError. Maybe introduced when @93014d525861f278aa60acace5ec15cae106ef25 merged. (closed by global: access errors import fix #2973)
  • ERROR: Expected package but found module at 'invenio.modules.upgrader.engine'.
  • ERROR: Could not generate upgrade - /tmp/tmpwNcF3O/invenio_upgrader_test/upgrades/invenio_upgrader_test_2015_03_31_rename_me.py already exists.

See all w/e: https://gist.githubusercontent.com/hachreak/2c34a5723795e0a34776/raw/master%20errors

@jirikuncar jirikuncar added this to the v2.x milestone Mar 30, 2015
@jirikuncar jirikuncar changed the title Tests warnings and errors tests: warnings and errors Mar 30, 2015
@jirikuncar jirikuncar changed the title tests: warnings and errors tests: investigate loud warnings and errors Mar 30, 2015
hachreak pushed a commit to hachreak/invenio that referenced this issue Mar 31, 2015
* FIX Fixes a import from access module.
  (addresses inveniosoftware#2967)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Mar 31, 2015
* FIX Fixes a import from access module.
  (addresses inveniosoftware#2967)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Mar 31, 2015
* FIX Fixes imports from access module.
  (addresses inveniosoftware#2967)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Mar 31, 2015
* FIX Fixes imports from access module.
  (addresses inveniosoftware#2967)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Mar 31, 2015
* FIX Fixes imports from access module.
  (addresses inveniosoftware#2967)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Mar 31, 2015
* Fixes imports from access module.
  (addresses inveniosoftware#2967)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Mar 31, 2015
* Fixes imports from access module.
  (addresses inveniosoftware#2967)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Apr 10, 2015
* Forces unicode literals on admin.
  (addresses inveniosoftware#2967)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Apr 10, 2015
* Forces unicode literals on views. (addresses inveniosoftware#2967)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Apr 10, 2015
* Forces unicode literals on all admin pages. (addresses inveniosoftware#2967)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Apr 10, 2015
* Forces unicode literals on views. (addresses inveniosoftware#2967)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Apr 10, 2015
* Forces unicode literals on all admin pages. (addresses inveniosoftware#2967)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Apr 10, 2015
* Forces unicode literals on views. (addresses inveniosoftware#2967)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Apr 10, 2015
* Forces unicode literals on all bundles. (addresses inveniosoftware#2967)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Apr 10, 2015
* Forces unicode literals on all bundles. (addresses inveniosoftware#2967)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Apr 10, 2015
* Forces unicode literals on views. (addresses inveniosoftware#2967)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Apr 10, 2015
* Forces unicode literals on all bundles. (addresses inveniosoftware#2967)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Apr 10, 2015
* Forces unicode literals on views. (addresses inveniosoftware#2967)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Apr 10, 2015
* Forces unicode literals on all bundles. (addresses inveniosoftware#2967)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Apr 10, 2015
* Forces unicode literals on config. (addresses inveniosoftware#2967)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Apr 23, 2015
* Removes a old hack for Invenio 1.x that loads utf-8 version of the
  list of languages instead of unicode. (addresses inveniosoftware#2967)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Apr 24, 2015
* Removes a old hack for Invenio 1.x that loads utf-8 version of the
  list of languages instead of unicode. (addresses inveniosoftware#2967)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Apr 24, 2015
* Removes a old hack for Invenio 1.x that loads utf-8 version of the
  list of languages instead of unicode. (addresses inveniosoftware#2967)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Apr 27, 2015
* Removes a old hack for Invenio 1.x that loads utf-8 version of the
  list of languages instead of unicode. (addresses inveniosoftware#2967)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue Apr 27, 2015
* Removes an old hack for Invenio 1.x that loads utf-8 version of the
  list of languages instead of unicode. (addresses inveniosoftware#2967)

Signed-off-by: Leonardo Rossi <[email protected]>
@dset0x
Copy link
Contributor

dset0x commented Apr 29, 2015

WorkflowError: WorkflowError(Error: ZeroDivisionError()

This is expected. The test checks if the engine allows the ZeroDivisionError to bubble up to the user. It could potentially be silenced, but it is not an actual problem with the test.

@jirikuncar
Copy link
Member

@dset0x that's fine. But the tests should not write to stderr unless they fail. If you expect something in stderr then catch it.

hachreak pushed a commit to hachreak/invenio that referenced this issue May 4, 2015
* Changes url_for to return always a unicode string. (addresses inveniosoftware#2967)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 4, 2015
* Changes url_for behaviour to return always a unicode string.
  (addresses inveniosoftware#2967)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 4, 2015
* Changes url_for behaviour to return always a unicode string.
  (addresses inveniosoftware#2967)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 4, 2015
* Changes url_for behaviour to return always a unicode string.
  (addresses inveniosoftware#2967)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 4, 2015
* Changes url_for behaviour to return always a unicode string.
  (addresses inveniosoftware#2967)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 4, 2015
* Changes url_for behaviour to return always a unicode string.
  (addresses inveniosoftware#2967)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 4, 2015
* Changes url_for behaviour to return always a unicode string.
  (addresses inveniosoftware#2967)

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 5, 2015
* Changes url_for behaviour to return always a unicode string.
  (addresses inveniosoftware#2967)

* Deprecates invenio.config hack for legacy code.

* Adds RemovedInInvenio24Warning class.

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 5, 2015
* Changes url_for behaviour to return always a unicode string.
  (addresses inveniosoftware#2967)

* Deprecates invenio.config hack for legacy code.

* Adds RemovedInInvenio24Warning class.

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 5, 2015
* Changes url_for behaviour to return always a unicode string.
  (addresses inveniosoftware#2967)

* Deprecates invenio.config hack for legacy code.

* Adds RemovedInInvenio24Warning class.

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 7, 2015
* Changes url_for behaviour to return always a unicode string.
  (addresses inveniosoftware#2967)

* Deprecates invenio.config hack for legacy code.

* Adds RemovedInInvenio24Warning class.

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 8, 2015
* Changes url_for behaviour to return always a unicode string.
  (addresses inveniosoftware#2967)

* Deprecates invenio.config hack for legacy code.

* Adds RemovedInInvenio24Warning class.

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 8, 2015
* Changes url_for behaviour to return always a unicode string.
  (addresses inveniosoftware#2967)

* Deprecates invenio.config hack for legacy code.

* Adds RemovedInInvenio24Warning class.

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 8, 2015
* Changes url_for behaviour to return always a unicode string.
  (addresses inveniosoftware#2967)

* Deprecates invenio.config hack for legacy code.

* Adds RemovedInInvenio24Warning class.

Signed-off-by: Leonardo Rossi <[email protected]>
hachreak pushed a commit to hachreak/invenio that referenced this issue May 8, 2015
* INCOMPATIBLE Changes url_for behaviour to return always a unicode
  string. (addresses inveniosoftware#2967)

* INCOMPATIBLE Deprecates invenio.config hack for legacy code.
  (addresses inveniosoftware#3106)

Signed-off-by: Leonardo Rossi <[email protected]>
Reviewed-by: Jiri Kuncar <[email protected]>
jmartinm pushed a commit to jmartinm/invenio that referenced this issue Jul 21, 2015
* Forces unicode literals on all admin pages. (addresses inveniosoftware#2967)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>
jmartinm pushed a commit to jmartinm/invenio that referenced this issue Jul 21, 2015
* Forces unicode literals on views. (addresses inveniosoftware#2967)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>
jmartinm pushed a commit to jmartinm/invenio that referenced this issue Jul 21, 2015
* Forces unicode literals on config. (addresses inveniosoftware#2967)

* PEP8/257 code style improvements.

Signed-off-by: Leonardo Rossi <[email protected]>
@tiborsimko
Copy link
Member

Superseded by Invenio 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants