refactoring-job-validation-email #2368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes preview: Legend: |
OlegPhenomenon
force-pushed
the
refactoring-job-validation-email
branch
2 times, most recently
from
a2181ee
to
5f70e81
Compare
OlegPhenomenon
force-pushed
the
refactoring-job-validation-email
branch
from
5f70e81
to
bc0a9d4
Compare
This was referenced Apr 26, 2022
thiagoyoussef
approved these changes
Apr 26, 2022
app/jobs/verify_emails_job.rb
Outdated
Comment on lines
51
to
55
| if data.failed? | ||
| return false if data.event_data['check_level'] == 'regex' | ||
|
|
||
| return true | ||
| end |
There was a problem hiding this comment.
I think here we could do something like this:
!(data.failed? && data.event_data['check_level'] == 'regex')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2364
TODO: Implement Force Delete checker by count of failed validation event records as separate job