Modified verify email rake task #2365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes preview: Legend: |
added 2 commits
April 22, 2022 17:14
|
PR can be close. The issue was different #2368 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2364
Modified verify email rake task so the contacts batch size and limit can be added as options:
bundle exec rake verify_email:check_all -- --batch_size=1000 --limit=100or
bundle exec rake verify_email:check_all -- -b1000 -l100By default batch_size is 10000 and limit is 0 (0 = unlimited).
NB! Changing batch_size will not stop the task from finding all the contacts, which need email validation. VerifyEmailsJob will start for each contact. Adjusting limit option will limit the amount of contacts that need to be validated, thus helping to protect from overloading by sidekiq jobs and to troubleshoot task problems in production environment.