- 
                Notifications
    You must be signed in to change notification settings 
- Fork 102
fix: updates to make e2e payment flow work #3668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 🚀 Performance Test ResultsTest Configuration: 
 Test Metrics: 
 📜 Logs | 
5a58520    to
    fd41d63      
    Compare
  
    
              
                    mkurapov
  
              
              commented
              
                  
                    Sep 26, 2025 
                  
              
              
            
            
| export interface AppServices { | ||
| logger: Promise<Logger> | ||
| config: Promise<IAppConfig> | ||
| paymentRoutes: Promise<PaymentRoutes> | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we can properly step into the functions
              
                    sanducb
  
              
              approved these changes
              
                  
                    Sep 26, 2025 
                  
              
              
            
            
    
  sanducb 
      added a commit
      that referenced
      this pull request
    
      Sep 26, 2025 
    
    
      
  
    
      
    
  
* feat(card-service): handle payment cancelled & funded events * feat(card-service): fix tests * fix: updates to make e2e payment flow work (#3668) * chore(localenv): add CARD_WEBHOOK_SERVICE_URL to cloud nine wallet backend * feat(backend): fetch cardDetails during outgoing payment funded and cancelled * chore(pos): correctly handle response from card service * test(pos): update card service client test * chore(card-service): add paymentRoutes to AppServices * chore(backend): fix withGraphFetched query * test(pos): remove unused test * fix(card-service): update payment result type * chore(card-service): format --------- Co-authored-by: Max Kurapov <[email protected]>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    pkg: backend
  Changes in the backend package. 
  
    type: source
  Changes business logic 
  
    type: tests
  Testing related 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Changes proposed in this pull request
CARD_WEBHOOK_SERVICE_URLto cloud nine backend docker compose fileContext
Related to #3654 | RAF-1168
Checklist
fixes #numberuser-docslabel (if necessary)