-
Couldn't load subscription status.
- Fork 101
feat(card-service): handle payment cancelled & funded events #3667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Performance Test ResultsTest Configuration:
Test Metrics:
📜 Logs |
| } | ||
|
|
||
| const requestId = identifiers.requestId | ||
| const deferred = paymentWaitMap.get(requestId) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't related to this PR, but for both card-service and POS service but most of the logic should live in the corresponding service.ts, as otherwise, we are coupling the "application layer" with our actual domain code. If made this, say, a GraphQL API, we shouldn't need to change any of the domain logic about how we are handling events and making the payment work.
In any case, let's get this working and we can do all kinds of polishing later :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created RAF_1174 for that 👍
| } | ||
|
|
||
| export type PaymentResult = PaymentEventBody | void | ||
| export type PaymentResult = PaymentResolution | void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need void?
* chore(localenv): add CARD_WEBHOOK_SERVICE_URL to cloud nine wallet backend * feat(backend): fetch cardDetails during outgoing payment funded and cancelled * chore(pos): correctly handle response from card service * test(pos): update card service client test * chore(card-service): add paymentRoutes to AppServices * chore(backend): fix withGraphFetched query * test(pos): remove unused test
Changes proposed in this pull request
This PR handles the
outgoing_payment.fundedandoutgoing_payment.cancelledevents that we are sending from the backend to the card service (RAF-1156)Context
Closes RAF-1168
Checklist
fixes #numberuser-docslabel (if necessary)