fix(backend): made CARD_SERVICE_URL optional

[oana-lolea]

Changes proposed in this pull request

• CARD_SERVICE_URL is now optional
• OpenPaymentsWalletAddress does not return cardServiceUrl if it's not set

Context

Fixes #3577
Linear #1113

Checklist

• Related issues linked using fixes #number
• Tests added/updated
• Make sure that all checks pass
• Bruno collection updated (if necessary)
• Documentation issue created with user-docs label (if necessary)
• OpenAPI specs updated (if necessary)

[github-actions]

🚀 Performance Test Results

Test Configuration:

• VUs: 4
• Duration: 1m0s

Test Metrics:

• Requests/s: 43.97
• Iterations/s: 14.66
• Failed Requests: 0.00% (0 of 2642)

📜 Logs

> [email protected] run-tests:testenv /home/runner/work/rafiki/rafiki/test/performance
> ./scripts/run-tests.sh -e test "-k" "-q" "--vus" "4" "--duration" "1m"

Cloud Nine GraphQL API is up: http://localhost:3101/graphql
Cloud Nine Wallet Address is up: http://localhost:3100/
Happy Life Bank Address is up: http://localhost:4100/
cloud-nine-wallet-test-backend already set
cloud-nine-wallet-test-auth already set
happy-life-bank-test-backend already set
happy-life-bank-test-auth already set
     data_received..................: 954 kB 16 kB/s
     data_sent......................: 2.0 MB 34 kB/s
     http_req_blocked...............: avg=6.12µs   min=2.05µs   med=4.87µs   max=626.25µs p(90)=5.88µs   p(95)=6.35µs  
     http_req_connecting............: avg=572ns    min=0s       med=0s       max=582.01µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=90.37ms  min=6.47ms   med=76.97ms  max=597.81ms p(90)=150.48ms p(95)=171.05ms
       { expected_response:true }...: avg=90.37ms  min=6.47ms   med=76.97ms  max=597.81ms p(90)=150.48ms p(95)=171.05ms
     http_req_failed................: 0.00%  ✓ 0         ✗ 2642
     http_req_receiving.............: avg=88.34µs  min=24.6µs   med=73.55µs  max=3.93ms   p(90)=111.26µs p(95)=144.73µs
     http_req_sending...............: avg=34.67µs  min=8.98µs   med=27.04µs  max=1.93ms   p(90)=38.67µs  p(95)=53.08µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=90.25ms  min=6.35ms   med=76.88ms  max=597.72ms p(90)=150.41ms p(95)=170.95ms
     http_reqs......................: 2642   43.974209/s
     iteration_duration.............: avg=272.64ms min=169.26ms med=257.17ms max=1.17s    p(90)=326.22ms p(95)=362.69ms
     iterations.....................: 881    14.663618/s
     vus............................: 4      min=4       max=4 
     vus_max........................: 4      min=4       max=4 

[mkurapov]

Let's remove this if and keep the cardService service defined, otherwise we might get unexpected behaviour if a singleton resolves to undefined.

[mkurapov]

We can do a NoopCardService (similar to the NoopTelemetryService)

[mkurapov]

Looks good, for the last comment feel free to push it directly to pos-card-services

[mkurapov]

Let's have a warn log here.