fix(backend): made CARD_SERVICE_URL optional (#3600)

* Made CARD_SERVICE_URL optional

* Created cardService container only if cardServiceUrl is set in config

* Added noop card service when cardServiceUrl is not provided

* Regenerated graphql

* Added warning when CARD_SERVICE_URL is not set

Author: oana-lolea

packages/backend/src/card/service.ts

@@ -36,6 +36,19 @@ export async function createCardService(
   }
 }
 
+export async function createNoopCardService(
+  logger: Logger
+): Promise<CardService> {
+  return {
+    async sendPaymentEvent(_eventDetails) {
+      // do nothing
+      logger.warn(
+        'CARD_SERVICE_URL env variable not set, falling back to NoopCardService'
+      )
+    }
+  }
+}
+
 async function sendPaymentEvent(
   deps: ServiceDependencies,
   eventDetails: EventDetails

packages/backend/src/config/app.ts

@@ -203,7 +203,7 @@ export const Config = {
     'SEND_TENANT_WEBHOOKS_TO_OPERATOR',
     false
   ),
-  cardServiceUrl: envString('CARD_SERVICE_URL')
+  cardServiceUrl: process.env.CARD_SERVICE_URL
 }
 
 function parseRedisTlsConfig(

packages/backend/src/index.ts

@@ -77,7 +77,7 @@ import { createTenantService } from './tenants/service'
 import { AuthServiceClient } from './auth-service-client/client'
 import { createTenantSettingService } from './tenants/settings/service'
 import { createPaymentMethodProviderService } from './payment-method/provider/service'
-import { createCardService } from './card/service'
+import { createCardService, createNoopCardService } from './card/service'
 
 BigInt.prototype.toJSON = function () {
   return this.toString()
@@ -673,11 +673,13 @@ export function initIocContainer(
   })
 
   container.singleton('cardService', async (deps) => {
-    return createCardService({
-      axios: await deps.use('axios'),
-      logger: await deps.use('logger'),
-      cardServiceUrl: config.cardServiceUrl
-    })
+    return config.cardServiceUrl
+      ? createCardService({
+          axios: await deps.use('axios'),
+          logger: await deps.use('logger'),
+          cardServiceUrl: config.cardServiceUrl
+        })
+      : createNoopCardService(await deps.use('logger'))
   })
 
   return container

packages/backend/src/open_payments/wallet_address/model.ts

@@ -123,7 +123,7 @@ export class WalletAddress
   }: {
     authServer: string
     resourceServer: string
-    cardService: string
+    cardService?: string
   }): OpenPaymentsWalletAddress {
     const returnVal: OpenPaymentsWalletAddress = {
       id: this.address,
@@ -132,7 +132,7 @@ export class WalletAddress
       assetScale: this.asset.scale,
       authServer,
       resourceServer,
-      cardService
+      ...(cardService && { cardService })
     }
     if (this.additionalProperties && this.additionalProperties.length) {
       returnVal.additionalProperties = this.additionalProperties

packages/backend/src/open_payments/wallet_address/routes.ts

@@ -63,7 +63,9 @@ export async function getWalletAddress(
   ctx.body = walletAddress.toOpenPaymentsType({
     authServer: `${ensureTrailingSlash(deps.config.authServerGrantUrl)}${walletAddress.tenantId}`,
     resourceServer: `${ensureTrailingSlash(deps.config.openPaymentsUrl)}${walletAddress.tenantId}`,
-    cardService: `${ensureTrailingSlash(deps.config.cardServiceUrl)}${walletAddress.tenantId}`
+    ...(deps.config.cardServiceUrl && {
+      cardService: `${ensureTrailingSlash(deps.config.cardServiceUrl)}${walletAddress.tenantId}`
+    })
   })
 }