Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.11.0 #1581

Merged
merged 22 commits into from
Nov 30, 2023
Merged

5.11.0 #1581

merged 22 commits into from
Nov 30, 2023

Conversation

LordOfPolls
Copy link
Contributor

No description provided.

AstreaTSS and others added 21 commits September 23, 2023 06:55
* chore: Version bump

Signed-off-by: LordOfPolls <[email protected]>

* Implemented role icon edit

* added role icon editing to the edit method

* Update misc_utils.py

* ci: correct from checks.

* fixed formatting, added return formatting indicator

* Noticed that interactions.client.utils.serializer

already had the functions I added to misc_utils. Undid those changes and tidied up the code in role.py to reflect the already existing converter.  Added an error raise if both icon and unicode emojis are used in one edit (the api requires only one is provided.)

* Cleaned up the docstring and moved the icon serialization

cleaned up the docstring to better align with requirements, moved the icon serialization so the payload's code is a bit easier to follow at a glance.

* Added UPLOADABLE_TYPE per comment

---------

Signed-off-by: LordOfPolls <[email protected]>
Co-authored-by: Katelyn Gigante <[email protected]>
Co-authored-by: LordOfPolls <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* ci: weekly check.

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.4.0 → v4.5.0](pre-commit/pre-commit-hooks@v4.4.0...v4.5.0)
- [github.com/astral-sh/ruff-pre-commit: v0.0.282 → v0.0.292](astral-sh/ruff-pre-commit@v0.0.282...v0.0.292)
- [github.com/psf/black: 23.7.0 → 23.9.1](psf/black@23.7.0...23.9.1)

* ci: correct from checks.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: LordOfPolls <[email protected]>
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.0.292 → v0.1.5](astral-sh/ruff-pre-commit@v0.0.292...v0.1.5)
- [github.com/psf/black: 23.9.1 → 23.11.0](psf/black@23.9.1...23.11.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* chore: Version bump

Signed-off-by: LordOfPolls <[email protected]>

* feat: support nitro basic PremiumType

---------

Signed-off-by: LordOfPolls <[email protected]>
Co-authored-by: Katelyn Gigante <[email protected]>
Co-authored-by: LordOfPolls <[email protected]>
* fix: Snowflake encoding issue when msgspec is used

Signed-off-by: Lacosst0 <[email protected]>

* Combine 2 isinstance into 1

Signed-off-by: Lacosst0 <[email protected]>

---------

Signed-off-by: Lacosst0 <[email protected]>
* feat: add support select menu defaults

* feat: add new objects to local scope __all__

* fix: use discordobject as base for dfaultselectvalue
…#1571)

* chore: Version bump

Signed-off-by: LordOfPolls <[email protected]>

* Removed self as first parameter to functions (not methods) in Guides.

---------

Signed-off-by: LordOfPolls <[email protected]>
Co-authored-by: Katelyn Gigante <[email protected]>
Co-authored-by: LordOfPolls <[email protected]>
* feat: add Client.mention_command

This makes it much easier to mention a command if you don't know how to use bot internals.

* docs: remove pointless typehint notes
* fix: ensure time trigger target is greater than last call time

* refactor: adjust fix to be more "proper"

* docs: document the weird fix
Signed-off-by: LordOfPolls <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (0129d53) 45.96% compared to head (730b0f0) 45.95%.

Files Patch % Lines
interactions/models/discord/components.py 52.38% 20 Missing ⚠️
interactions/client/smart_cache.py 14.28% 6 Missing ⚠️
interactions/models/discord/role.py 33.33% 4 Missing ⚠️
interactions/ext/paginators.py 0.00% 3 Missing ⚠️
interactions/models/discord/guild.py 25.00% 3 Missing ⚠️
...teractions/models/internal/application_commands.py 0.00% 3 Missing ⚠️
...ractions/api/events/processors/scheduled_events.py 0.00% 2 Missing ⚠️
interactions/api/gateway/state.py 0.00% 1 Missing ⚠️
interactions/client/client.py 50.00% 1 Missing ⚠️
interactions/client/utils/input_utils.py 50.00% 1 Missing ⚠️
... and 3 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           stable    #1581      +/-   ##
==========================================
- Coverage   45.96%   45.95%   -0.01%     
==========================================
  Files         144      144              
  Lines       15437    15492      +55     
==========================================
+ Hits         7096     7120      +24     
- Misses       8341     8372      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LordOfPolls
Copy link
Contributor Author

Mergability conflict fixed - this is stable and ready for merge

Copy link
Member

@AstreaTSS AstreaTSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is so funny being nearly half of the commits for this release

eightween

This comment was marked as off-topic.

Copy link
Contributor

@i0bs i0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we putting all breaking changes on backburner for 6.x? when are we moving to working on it?

@LordOfPolls LordOfPolls merged commit 1a7de56 into stable Nov 30, 2023
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.