fix: properly check if name is none for anno names #1555
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
This fixes #1554 by properly checking if
option.name
is None. Previously, it was incorrectly assuming thatname
would be kept asNone
when passing it into theSlashCommandOption
's init, when that doesn't seem to be the case (anymore? I swore this didn't happen before). Instead, it was aLocalisedName
, and now the logic for the names accounts for that (and also properly sets the new name variable too).Changes
See description.
Related Issues
#1554
Test Scenarios
Python Compatibility
3.10.x
3.11.x
Checklist
pre-commit
code linter over all edited files