Skip to content

fix: filter out Nones from guild.role before sorting #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LordOfPolls merged 1 commit into from
Jun 24, 2023
Merged

fix: filter out Nones from guild.role before sorting #1457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions interactions/models/discord/guild.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,8 +369,7 @@ def humans(self) -> List["models.Member"]:
@property
def roles(self) -> List["models.Role"]:
"""Returns a list of roles associated with this guild."""
roles = sorted((self._client.cache.get_role(r_id) for r_id in self._role_ids), reverse=True)
return [r for r in roles if r]
return sorted((r for r_id in self._role_ids if (r := self._client.cache.get_role(r_id))), reverse=True)

@property
def me(self) -> "models.Member":
Expand Down