fix: filter out Nones from guild.role before sorting

[AstreaTSS]

Pull Request Type

• Feature addition
• Bugfix
• Documentation update
• Code refactor
• Tests improvement
• CI/CD pipeline enhancement
• Other: [Replace with a description]

Description

Yes, this is a bug fix to a bug fix. More specifically #1454.
Basically, if the cache returned None for a role, sorted would still try to sort those Nones as they haven't been filtered out yet... so you can end up in scenarios where it tries to compare a NoneType to a NoneType.

Changes

• Use a funny list comprehension to filter out Nones in the generator passed to sorted for guild.roles.

Related Issues

Test Scenarios

Python Compatibility

• I've ensured my code works on Python 3.10.x
• I've ensured my code works on Python 3.11.x

Checklist

• I've run the pre-commit code linter over all edited files
• I've tested my changes on supported Python versions
• I've added tests for my code, if applicable
• I've updated / added documentation, where applicable

[LordOfPolls]

ick... but approved

[AstreaTSS]

smh this code is totally very clean and the best example of walrus operators

[silasary]

And it's much more performant than the old code