Skip to content

Commit

Permalink
fix(PathRequest): remove incorrect assert (XRPLF#4743)
Browse files Browse the repository at this point in the history
The assert is saying that the only reason `pathFinder` would be null is
if the request was aborted (connection dropped, etc.). That's what
`continueCallback()` checks. But that is very clearly not true if you
look at `getPathFinder`, which calls `findPaths`, which can return false
for many reasons.

Fix XRPLF#4744
  • Loading branch information
ximinez authored Oct 12, 2023
1 parent 1151fba commit 50cc1cf
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/ripple/app/paths/PathRequest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,6 @@ PathRequest::findPaths(
continueCallback);
if (!pathfinder)
{
assert(continueCallback && !continueCallback());
JLOG(m_journal.debug()) << iIdentifier << " No paths found";
continue;
}
Expand Down

0 comments on commit 50cc1cf

Please sign in to comment.