[TRIVIAL] Remove incorrect assert #4743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The assert is saying that the only reason pathFinder would be null is if the request was aborted (connection dropped, etc.). That's what continueCallback() checks. But that is very clearly not true if you look at getPathFinder, which calls findPaths, which can return false for all kinds of reasons.
HowardHinnant
approved these changes
Oct 9, 2023
|
This PR has sufficient approvals. @ximinez , feel free to apply the |
ximinez
added
the
Passed
* upstream/develop: fix(CI): update workflow for uploading binaries to artifactory (4746)
Bronek
pushed a commit
to Bronek/rippled
that referenced
this pull request
Oct 17, 2023
The assert is saying that the only reason `pathFinder` would be null is if the request was aborted (connection dropped, etc.). That's what `continueCallback()` checks. But that is very clearly not true if you look at `getPathFinder`, which calls `findPaths`, which can return false for many reasons. Fix XRPLF#4744
sophiax851
pushed a commit
to sophiax851/rippled
that referenced
this pull request
Jun 12, 2024
The assert is saying that the only reason `pathFinder` would be null is if the request was aborted (connection dropped, etc.). That's what `continueCallback()` checks. But that is very clearly not true if you look at `getPathFinder`, which calls `findPaths`, which can return false for many reasons. Fix XRPLF#4744
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
An assert in PathRequest.cpp at line 541 can fire falsely in some circumstances:
The assert is saying that the only reason
pathFinderwould be null is if the request was aborted (connection dropped, etc.). That's whatcontinueCallback()checks. But that is very clearly not true if you look atgetPathFinder, which callsfindPaths, which can return false for all kinds of reasons.This PR removes that assert.
Type of Change
Resolved #4744