Skip to content

Conversation

@lvliang-intel
Copy link
Contributor

Signed-off-by: Lv, Liang1 [email protected]

Type of Change

feature
API changed

Description

detail description
JIRA ticket: ILITV-2456
INC New API TF examples(resnetv2_50,xception,inception_resnet_v2,resnet_v2)

Expected Behavior & Potential Risk

Tensorflow examples with partial build-in func or without build-in func, update to new API and Config class.

How has this PR been tested?

UT, Pre-CI test.

Dependency Change?

No.

@chensuyue
Copy link
Contributor

chensuyue commented Nov 29, 2022

  1. delete config yaml.
  2. unify data input with "--dataset_location=", we use the same dataset for calib and eval.
  3. benchmark require "--mode=(accuracy/performance)", BenchmarkConfig is performance only.
    if mode==“accuracy”:
    eval_func()
    else:
    benchmark.fit(BenchmarkConfig(...), b_dataloader…)
  4. Need to unify the why to handle ITEX gpu case. How to set gpu without yaml, with input param or ask user to add device=gpu in code?
  5. Need to modify 'model_params_tensorflow.json', validation need to judge newAPI from the params list.
    "mode_name": {
    "model_src_dir": "xxx",
    "dataset_location": "xxx",
    "input_model": "xxx",
    "main_script": "xxx",
    "batch_size": 64
    },

@chensuyue
Copy link
Contributor

WenjiaoYue and others added 20 commits December 5, 2022 15:22
Signed-off-by: Yue, Wenjiao <[email protected]>
Signed-off-by: Lv, Liang1 <[email protected]>
Signed-off-by: Lv, Liang1 <[email protected]>
Signed-off-by: Yue, Wenjiao <[email protected]>
Co-authored-by: chen, suyue <[email protected]>
Signed-off-by: Lv, Liang1 <[email protected]>
Signed-off-by: chensuyue <[email protected]>
Signed-off-by: Lv, Liang1 <[email protected]>
Signed-off-by: Cheng, Penghui <[email protected]>
Signed-off-by: Lv, Liang1 <[email protected]>
Signed-off-by: Yue, Wenjiao <[email protected]>
Signed-off-by: Lv, Liang1 <[email protected]>
… QDQ (#184)

* Create onnx_inc_static_quant_qdqyaml

* Rename onnx_inc_static_quant_qdqyaml to onnx_inc_static_quant_qdq.yaml

* Create onnx_inc_dynamic_quant.yaml

Signed-off-by: Lv, Liang1 <[email protected]>
* Fixed UT error for bf16 op list for QAT mode

Signed-off-by: Cheng, Penghui <[email protected]>
Signed-off-by: Lv, Liang1 <[email protected]>
Signed-off-by: Wang, Chang1 <[email protected]>
Signed-off-by: Lv, Liang1 <[email protected]>
@chensuyue
Copy link
Contributor

@chensuyue
Copy link
Contributor

extension test
pls check the performance gap.

@chensuyue
Copy link
Contributor

extension test
minor issue need to fix, and pls rebuild the extension job with the failed model after bug fix.

Signed-off-by: Lv, Liang1 <[email protected]>
Copy link
Contributor

@hshen14 hshen14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chensuyue
Copy link
Contributor

still bas some performance gap, need to double check.

@chensuyue
Copy link
Contributor

extension test

@chensuyue chensuyue merged commit 317f246 into master Dec 16, 2022
@chensuyue chensuyue deleted the lvl/inc_newapi_tf_examples branch December 16, 2022 09:32
yiliu30 pushed a commit that referenced this pull request Apr 5, 2025
xin3he pushed a commit that referenced this pull request Apr 22, 2025
XuehaoSun pushed a commit that referenced this pull request May 13, 2025
This was referenced Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.