Skip to content

Conversation

@yiliu30
Copy link
Contributor

@yiliu30 yiliu30 commented Nov 27, 2022

Signed-off-by: yiliu30 [email protected]

Type of Change

  • bug fix
  • API changed or not: None

Description

Adjust the hyperopt and sigopt as extras requirements.
JIRA ticket: ILITV-2452

Expected Behavior & Potential Risk

hyperopt and sigopt are not hard dependencies.

How has this PR been tested?

Pre-CI

Dependency Change?

Any library dependency introduced or removed:

  • hyperopt is required only when the user uses tpe strategy.
  • sigopt is required only when the user uses sigopt strategy.

@yiliu30
Copy link
Contributor Author

yiliu30 commented Nov 28, 2022

The Pre-CI test failed with a performance regression which may be a random issue caused by the differences in test nodes.

image

@yiliu30 yiliu30 requested review from chensuyue and ftian1 November 28, 2022 02:10
@chensuyue
Copy link
Contributor

The Pre-CI test failed with a performance regression which may be a random issue caused by the differences in test nodes.

image

Yes, you are right.

@chensuyue chensuyue merged commit 477725e into master Nov 29, 2022
@chensuyue chensuyue deleted the ly/update_dep branch November 29, 2022 07:33
macsz pushed a commit that referenced this pull request Nov 30, 2022
chensuyue added a commit that referenced this pull request Dec 1, 2022
lvliang-intel pushed a commit that referenced this pull request Dec 5, 2022
yiliu30 added a commit that referenced this pull request Dec 7, 2022
zehao-intel pushed a commit that referenced this pull request Dec 9, 2022
zehao-intel pushed a commit that referenced this pull request Dec 20, 2022
This was referenced Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants