Skip to content

[SYCL] Recognise visited nodes in local accessor to shared mem pass #5859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bader merged 3 commits into from
Mar 23, 2022
Merged

[SYCL] Recognise visited nodes in local accessor to shared mem pass #5859

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
adfcecf
[SYCL] Recognise visited nodes in local accessor to shared mem pass
jchlanda Mar 22, 2022
aa2eaeb
correctly check for visited md
jchlanda Mar 22, 2022
d9cbbb1
Regression test for multiple nodes in annotations
jchlanda Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion llvm/lib/SYCLLowerIR/LocalAccessorToSharedMemory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
//===----------------------------------------------------------------------===//

#include "llvm/SYCLLowerIR/LocalAccessorToSharedMemory.h"
#include "llvm/ADT/SmallSet.h"
#include "llvm/IR/Constants.h"
#include "llvm/IR/GlobalValue.h"
#include "llvm/IR/Instructions.h"
Expand Down Expand Up @@ -248,10 +249,15 @@ class LocalAccessorToSharedMemory : public ModulePass {
if (!NvvmMetadata)
return;

// It is possible that the annotations node contains multiple pointers to
// the same metadata, recognise visited ones.
SmallSet<MDNode *, 4> Visited;
for (auto *MetadataNode : NvvmMetadata->operands()) {
if (MetadataNode->getNumOperands() != 3)
if (Visited.contains(MetadataNode) || MetadataNode->getNumOperands() != 3)
Comment thread
bader marked this conversation as resolved.
continue;

Visited.insert(MetadataNode);

// NVPTX identifies kernel entry points using metadata nodes of the form:
// !X = !{<function>, !"kernel", i32 1}
const MDOperand &TypeOperand = MetadataNode->getOperand(1);
Expand Down