Skip to content

[SYCL] Recognise visited nodes in local accessor to shared mem pass #5859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bader merged 3 commits into from
Mar 23, 2022
Merged

[SYCL] Recognise visited nodes in local accessor to shared mem pass #5859

bader merged 3 commits into from
Mar 23, 2022

Conversation

@jchlanda
Copy link
Contributor

@jchlanda jchlanda commented Mar 22, 2022

It's possible that clang would store multiple pointers to the same MDNode in the annotations metadata, keep track of visited ones while populating the kernels.

Fixes #5600

@jchlanda jchlanda requested a review from a team as a code owner March 22, 2022 14:37
@jchlanda jchlanda mentioned this pull request Mar 22, 2022
Closed
bader
bader reviewed Mar 22, 2022
View reviewed changes
@jchlanda jchlanda requested a review from bader March 22, 2022 14:48
bader
bader previously approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think we should add a regression test for the case from #5600.

@jchlanda
Copy link
Contributor Author

jchlanda commented Mar 22, 2022

LGTM. I think we should add a regression test for the case from #5600.

kk, will do it now.

@jchlanda jchlanda force-pushed the jakub/local_acc_mdnode_fix branch from eb9b447 to d9cbbb1 Compare March 22, 2022 15:11
@jchlanda
Copy link
Contributor Author

jchlanda commented Mar 22, 2022

LGTM. I think we should add a regression test for the case from #5600.

kk, will do it now.

Done in eb9b44799cba2f136c4c5dc54f32d5799632936b

@bader bader merged commit 57e935a into intel:sycl Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bader bader bader approved these changes

+1 more reviewer

@mlychkov mlychkov mlychkov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compiler crash at pass 'SYCL Local Accessor to Shared Memory' on CUDA backend caused by https://github.com/intel/llvm/pull/5149

3 participants

@jchlanda @bader @mlychkov