Skip to content

[SYCL][Docs] Add new rule for naming C++ identifiers in SYCL project #5843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bader merged 8 commits into from
Mar 23, 2022
Merged

[SYCL][Docs] Add new rule for naming C++ identifiers in SYCL project #5843

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3610aa6
[SYCL][Docs] Implementataion of new rule of naming variables in sycl …
HabKaffee Mar 21, 2022
46250dd
apply suggested changes
HabKaffee Mar 21, 2022
c15fcab
change rule according to notes
HabKaffee Mar 22, 2022
03c74b2
Merge branch 'sycl' into change_naming_rule
HabKaffee Mar 22, 2022
77bd094
Add rule about max line length
HabKaffee Mar 22, 2022
29a7aed
Update sycl/doc/developer/ContributeToDPCPP.md
HabKaffee Mar 22, 2022
5ea736d
Update sycl/doc/developer/ContributeToDPCPP.md
bader Mar 22, 2022
77db022
Update sycl/doc/developer/ContributeToDPCPP.md
HabKaffee Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sycl/doc/developer/ContributeToDPCPP.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ end-to-end or SYCL-CTS tests.
- Add a helpful comment describing what the test does at the beginning and
other comments throughout the test as necessary.

- Start all variables' name in llvm/sycl `.h` and `.cpp` (weather template or function variables) with underscore (`_`).
Comment thread
bader marked this conversation as resolved.
Outdated

- Try to follow descriptive naming convention for variables, functions as
much as possible. Please refer to
[LLVM naming convention](https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly)
Expand Down