[SYCL][Docs] Add new rule for naming C++ identifiers in SYCL project#5843
Merged
bader merged 8 commits intointel:syclfrom Mar 23, 2022
Merged
[SYCL][Docs] Add new rule for naming C++ identifiers in SYCL project#5843bader merged 8 commits intointel:syclfrom
bader merged 8 commits intointel:syclfrom
Conversation
…headers and source files
bader
requested changes
Mar 21, 2022
bader
reviewed
Mar 21, 2022
bader
reviewed
Mar 22, 2022
bader
reviewed
Mar 22, 2022
Contributor
bader
left a comment
bader
left a comment
There was a problem hiding this comment.
Sorry for confusion. I was talking about the text you add to this document.
Co-authored-by: Alexey Bader <alexey.bader@intel.com>
bader
reviewed
Mar 22, 2022
bader
previously approved these changes
Mar 22, 2022
Contributor
bader
left a comment
bader
left a comment
There was a problem hiding this comment.
@romanovvlad, @s-kanaev, please, share your thoughts on this.
bader
changed the title
romanovvlad
reviewed
Mar 22, 2022
Co-authored-by: Romanov Vlad <vlad.romanov@intel.com>
bader
approved these changes
Mar 23, 2022
romanovvlad
approved these changes
Mar 23, 2022
Contributor
|
@s-kanaev, could you take a look, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new rule of naming C++ identifiers in
llvm/syclfiles. It aims to exclude possibility to fail SYCL app compilation by defining macros before includingCL/sycl.hpp.