[SYCL] Fix a few warnings during build scripts configuration#5082
[SYCL] Fix a few warnings during build scripts configuration#5082bader merged 2 commits intointel:syclfrom
Conversation
bader
left a comment
There was a problem hiding this comment.
Is the goal of this patch to make CMake configuration step free from warnings?
If so, we need to fix this warning:
CMake Warning (dev) in /localdisk2/sycl_ci/buildbot/worker/Lit_With_Cuda/llvm.src/libclc/CMakeLists.txt:
A logical block opening on the line
/localdisk2/sycl_ci/buildbot/worker/Lit_With_Cuda/llvm.src/libclc/CMakeLists.txt:86 (if)
closes on the line
/localdisk2/sycl_ci/buildbot/worker/Lit_With_Cuda/llvm.src/libclc/CMakeLists.txt:88 (endif)
Tagging code author for awareness - @Naghasan.
@AlexeySotkin, @AlexeySachkov, please, help with disabling SPIR-V translator project related warnings:
CMake Warning at /localdisk2/sycl_ci/buildbot/worker/Lit_With_Cuda/llvm.src/llvm-spirv/test/CMakeLists.txt:32 (message):
spirv-as not found! SPIR-V assembly tests will not be run.
CMake Warning at /localdisk2/sycl_ci/buildbot/worker/Lit_With_Cuda/llvm.src/llvm-spirv/test/CMakeLists.txt:37 (message):
spirv-link not found! SPIR-V test involving the linker will not be run.
CMake Warning at /localdisk2/sycl_ci/buildbot/worker/Lit_With_Cuda/llvm.src/llvm-spirv/test/CMakeLists.txt:42 (message):
spirv-val not found! SPIR-V generated for test suite will not be validated.
bader
left a comment
There was a problem hiding this comment.
I found one more warning on Windows:
-- Performing Test HAVE_POSIX_REGEX -- failed to compile
CMake Warning at utils/benchmark/CMakeLists.txt:248 (message):
Using std::regex with exceptions disabled is not fully supported
This warning is related to benchmark tests, so we need to turn on BENCHMARK_ENABLE_EXCEPTIONS to fix it, but how does this affect the performance of such tests? |
|
From the offline discussion, I got an impression that your goal is not fix all the warnings. AFAIK, DPC++ doesn't use "benchmark test", so I don't think we should fix this warning. |
Thanks for the fix :) |
|
I think that warnings about spirv is quite important, so they should remain. |
I don't think emitting warnings is a good choice for missing tools notification, I think |
my 2 cents: part of the testing depends on these tools, so I think warning is the appropriate choice. |
* upstream/sycl: (725 commits) [SYCL] Translate ZE_RESULT_ERROR_INVALID_ARGUMENT error code from L0 RT (intel#5122) [SYCL][L0][Plugin] Call ZeCommandQueueCreate on demand (intel#5109) [SYCL] Switch to using blocking USM free for OpenCL GPU (intel#4928) [CI] Disable pack and upload steps (intel#5119) [SYCL] Disable submission of AssertInfoCopier for FPGA (intel#4780) [SYCL][SPIRV] Implement islessgreater with FOrdNotEqual instead (intel#5076) [SYCL] Fix typo in the name of the host-visible pool (intel#5073) [SYCL] Only call shutdown when DLL is being unloaded, not when process is terminating (intel#4983) [SYCL][CUDA][PI] Fix infinite loop when parallel_for range exceeds INT_MAX (intel#5095) [SYCL] Translate out-of-memory error codes from L0 RT (intel#5107) [SYCL] Fix a few warnings during build scripts configuration (intel#5082) [SYCL] Fix amdgpu openmp test (intel#5103) [SYCL] [FPGA] Create experimental headers for FPGA latency control (intel#5066) [SYCL][CUDA] Don't enqueue an event wait on same CUDA stream (intel#5099) Remove PR disable template (intel#5102) [BuildBot]Uplift CPU/FPGAEMU RT version (intel#5078) [SYCL] Fix the test to not depend on a specific line. (intel#5092) [CI] Provide libclc targets to build and test (intel#5091) Fix build of `check-llvm-spirv` target after 8f8001a Force opt to use new pass manager in pr52289 test after c34d157 ...
* upstream/sycl: [CI] Add container users to video group (intel#5101) [CI] More typo fixes in Nightly build (intel#5088) Revert "[CI] Disable pack and upload steps (intel#5119)" (intel#5125) [SYCL] Translate ZE_RESULT_ERROR_INVALID_ARGUMENT error code from L0 RT (intel#5122) [SYCL][L0][Plugin] Call ZeCommandQueueCreate on demand (intel#5109) [SYCL] Switch to using blocking USM free for OpenCL GPU (intel#4928) [CI] Disable pack and upload steps (intel#5119) [SYCL] Disable submission of AssertInfoCopier for FPGA (intel#4780) [SYCL][SPIRV] Implement islessgreater with FOrdNotEqual instead (intel#5076) [SYCL] Fix typo in the name of the host-visible pool (intel#5073) [SYCL] Only call shutdown when DLL is being unloaded, not when process is terminating (intel#4983) [SYCL][CUDA][PI] Fix infinite loop when parallel_for range exceeds INT_MAX (intel#5095) [SYCL] Translate out-of-memory error codes from L0 RT (intel#5107) [SYCL] Fix a few warnings during build scripts configuration (intel#5082) [SYCL] Fix amdgpu openmp test (intel#5103) [SYCL] [FPGA] Create experimental headers for FPGA latency control (intel#5066) [SYCL][CUDA] Don't enqueue an event wait on same CUDA stream (intel#5099) Remove PR disable template (intel#5102) [BuildBot]Uplift CPU/FPGAEMU RT version (intel#5078)
No description provided.