[SYCL] Only call shutdown when DLL is being unloaded, not when process is terminating#4983
Merged
romanovvlad merged 7 commits intointel:syclfrom Dec 9, 2021
Merged
Conversation
…s is terminating Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
cperkinsintel
previously approved these changes
Nov 18, 2021
Contributor
cperkinsintel
left a comment
cperkinsintel
left a comment
There was a problem hiding this comment.
as per the docs that were shared, this looks good to me.
Is there any test we can add to confirm?
Contributor
Author
I can't think of any proper test except for launch and finish some dummy application and employing windows sort of |
Contributor
Can't we check output of SYCL_PI_TRACE for cases when |
alexbatashev
previously approved these changes
Nov 22, 2021
Contributor
Author
This might be feasible within an OS-specific unit-test with explicit call to DllMain. I'll add another commit here. |
added 3 commits
November 23, 2021 17:35
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
s-kanaev
dismissed stale reviews from alexbatashev and cperkinsintel
via
9832e6e
added 2 commits
December 2, 2021 15:44
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Contributor
Author
|
@cperkinsintel , @alexbatashev , I've added a unit-test. Please, review. |
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
s-kanaev
force-pushed
the
fix-windows-shutdown
branch
from
faeb978 to
c183ba7
Compare
alexbatashev
approved these changes
Dec 3, 2021
Contributor
alexbatashev
left a comment
alexbatashev
left a comment
There was a problem hiding this comment.
LGTM, comments are minor
| extern "C" BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, | ||
| LPVOID lpReserved); | ||
|
|
||
| static std::atomic<int> TearDownCalls{0}; |
Contributor
There was a problem hiding this comment.
Nit. I would add a static_assert to check that this atomic is trivially destructible.
Contributor
|
@s-kanaev, I don't have anything to add here. |
alexbatashev
added a commit
to alexbatashev/llvm
that referenced
this pull request
Dec 11, 2021
* upstream/sycl: (725 commits) [SYCL] Translate ZE_RESULT_ERROR_INVALID_ARGUMENT error code from L0 RT (intel#5122) [SYCL][L0][Plugin] Call ZeCommandQueueCreate on demand (intel#5109) [SYCL] Switch to using blocking USM free for OpenCL GPU (intel#4928) [CI] Disable pack and upload steps (intel#5119) [SYCL] Disable submission of AssertInfoCopier for FPGA (intel#4780) [SYCL][SPIRV] Implement islessgreater with FOrdNotEqual instead (intel#5076) [SYCL] Fix typo in the name of the host-visible pool (intel#5073) [SYCL] Only call shutdown when DLL is being unloaded, not when process is terminating (intel#4983) [SYCL][CUDA][PI] Fix infinite loop when parallel_for range exceeds INT_MAX (intel#5095) [SYCL] Translate out-of-memory error codes from L0 RT (intel#5107) [SYCL] Fix a few warnings during build scripts configuration (intel#5082) [SYCL] Fix amdgpu openmp test (intel#5103) [SYCL] [FPGA] Create experimental headers for FPGA latency control (intel#5066) [SYCL][CUDA] Don't enqueue an event wait on same CUDA stream (intel#5099) Remove PR disable template (intel#5102) [BuildBot]Uplift CPU/FPGAEMU RT version (intel#5078) [SYCL] Fix the test to not depend on a specific line. (intel#5092) [CI] Provide libclc targets to build and test (intel#5091) Fix build of `check-llvm-spirv` target after 8f8001a Force opt to use new pass manager in pr52289 test after c34d157 ...
alexbatashev
added a commit
to alexbatashev/llvm
that referenced
this pull request
Dec 12, 2021
* upstream/sycl: [CI] Add container users to video group (intel#5101) [CI] More typo fixes in Nightly build (intel#5088) Revert "[CI] Disable pack and upload steps (intel#5119)" (intel#5125) [SYCL] Translate ZE_RESULT_ERROR_INVALID_ARGUMENT error code from L0 RT (intel#5122) [SYCL][L0][Plugin] Call ZeCommandQueueCreate on demand (intel#5109) [SYCL] Switch to using blocking USM free for OpenCL GPU (intel#4928) [CI] Disable pack and upload steps (intel#5119) [SYCL] Disable submission of AssertInfoCopier for FPGA (intel#4780) [SYCL][SPIRV] Implement islessgreater with FOrdNotEqual instead (intel#5076) [SYCL] Fix typo in the name of the host-visible pool (intel#5073) [SYCL] Only call shutdown when DLL is being unloaded, not when process is terminating (intel#4983) [SYCL][CUDA][PI] Fix infinite loop when parallel_for range exceeds INT_MAX (intel#5095) [SYCL] Translate out-of-memory error codes from L0 RT (intel#5107) [SYCL] Fix a few warnings during build scripts configuration (intel#5082) [SYCL] Fix amdgpu openmp test (intel#5103) [SYCL] [FPGA] Create experimental headers for FPGA latency control (intel#5066) [SYCL][CUDA] Don't enqueue an event wait on same CUDA stream (intel#5099) Remove PR disable template (intel#5102) [BuildBot]Uplift CPU/FPGAEMU RT version (intel#5078)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.