"[SPIRV] Implement translation for llvm.modf.* intrinsics (#147556)" cherry-pick #19725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on KhronosGroup/SPIRV-LLVM-Translator#3100, I'm adding translation for `llvm.modf.*` intrinsics.
maarquitos14
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
approved these changes
Aug 6, 2025
Contributor
aelovikov-intel
left a comment
aelovikov-intel
left a comment
There was a problem hiding this comment.
SYCL RT LGTM, but I think the title/description should just be copied from the upstream and then appended with cherry-picking info/downstream specifics
maarquitos14
changed the title
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
approved these changes
Aug 6, 2025
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
vmaksimo
approved these changes
Aug 6, 2025
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
@intel/llvm-gatekeepers this is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick the patch llvm/llvm-project@1d02de28dd6:
And reenable tests that were unsupported because of this issue.
Fixes #17813.