Add translation for llvm.modf.* #3100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
MrSidims
approved these changes
Mar 26, 2025
| declare float @llvm.atan2.f32(float, float) | ||
|
|
||
| ; CHECK: Function | ||
| ; CHECK: FunctionParameter {{[0-9]+}} [[x:[0-9]+]] |
There was a problem hiding this comment.
Please add a check for OpVariable
lib/SPIRV/SPIRVWriter.cpp
Outdated
| BM->addPointerType(StorageClassFunction, IntegralTy); | ||
| SPIRVValue *Ptr = BM->addVariable(IntegralPtrTy, nullptr, false, | ||
| spv::internal::LinkageTypeInternal, | ||
| nullptr, "", StorageClassFunction, BB); |
There was a problem hiding this comment.
Ideally it should be not current BB, but entry BB of the functions to satisfy "All OpVariable instructions in a function must be in the first block in the function".
SPIRVFunction class in the translator has BB vector, so it might be possible to query first basic block and then call getVariableInsertionPoint to get a place where to insert OpVariable (or alternatively just create alloca in the beginning of the function using LLVM API and call transValue here).
svenvh
approved these changes
Mar 31, 2025
MrSidims
approved these changes
Mar 31, 2025
jsji
added a commit
to intel/llvm
that referenced
this pull request
Apr 2, 2025
AlexeySachkov
pushed a commit
to intel/llvm
that referenced
this pull request
May 28, 2025
MrSidims
pushed a commit
to llvm/llvm-project
that referenced
this pull request
Jul 21, 2025
Based on KhronosGroup/SPIRV-LLVM-Translator#3100, I'm adding translation for `llvm.modf.*` intrinsics.
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Jul 21, 2025
…#147556) Based on KhronosGroup/SPIRV-LLVM-Translator#3100, I'm adding translation for `llvm.modf.*` intrinsics.
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Jul 28, 2025
Based on KhronosGroup/SPIRV-LLVM-Translator#3100, I'm adding translation for `llvm.modf.*` intrinsics.
maarquitos14
added a commit
to maarquitos14/llvm
that referenced
this pull request
Aug 6, 2025
Based on KhronosGroup/SPIRV-LLVM-Translator#3100, I'm adding translation for `llvm.modf.*` intrinsics.
againull
pushed a commit
to intel/llvm
that referenced
this pull request
Aug 6, 2025
…cherry-pick (#19725) Cherry-pick the patch llvm/llvm-project@1d02de28dd6: ``` Based on KhronosGroup/SPIRV-LLVM-Translator#3100, I'm adding translation for `llvm.modf.*` intrinsics. ``` And reenable tests that were unsupported because of this issue. Fixes #17813.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add translation for
llvm.modf.*intrinsics.