Eliminated redundancy in plugin initialization. #1868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks very similar to #1614. |
Contributor
@bader It intentionally is. It additionally resolves the comment in https://github.com/intel/llvm/pull/1614/files#r423770533 The #1614 should be abandoned in favor of this PR. |
smaslov-intel
previously approved these changes
Jun 10, 2020
Contributor
Okay. Thanks for the update. @smaslov-intel, please, close #1614. |
Passed the implementation of pi initialization into a "call_once" function, so that plugin initiliazation only needs to be executed once. After the first time, the already initiliazed plugin will be returned. Also, updated pi::initialize to return const reference to the global vector of plugins, rather than a temporary copy of it.
kholland-intel
force-pushed
the
kholland/pi_initialize
branch
from
1762298 to
db8d682
Compare
smaslov-intel
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passed the implementation of pi initialization into a "call_once" function, so
that plugin initiliazation only needs to be executed once. After the first time,
the already initiliazed plugin will be returned.
Also, updated pi::initialize to return const reference to the global vector of
plugins, rather than a temporary copy of it.