-
Notifications
You must be signed in to change notification settings - Fork 801
[SYCL] Add OpenCL interop API following SYCL-2020 backend generalization #1846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4b3f06f to
bef3076
Compare
steffenlarsen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments but otherwise LGTM.
f6acb77 to
c57acef
Compare
rbegam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c57acef to
8c0d3d5
Compare
|
Sorry for force-push. Re-based on top of recently merged #1868 which is essential for the |
nyalloc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to see this stuff in the OpenCL backend now.
Signed-off-by: Sergey V Maslov <[email protected]>
8c0d3d5 to
bbc2a9c
Compare
|
Can someone tell what are the fails in |
|
@alexanderfle , do you think this might be related to #1872 (comment)? |
|
@smaslov-intel , As for me, I don’t see any connections here except the same buildbot output of the LIT_With_Cuda for one of my commit. |
@alexanderfle, can you see in the output what failed and how? |
No, and I have the same questions:
|
…ter, integral) Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
alexbatashev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This patch implements the initial support for the new debug specification NonSemantic.Kernel.DebugInfo.100. It also introduces support for the new debug instruction DISubrange. Spec: KhronosGroup/SPIRV-Registry#186 Original commit: KhronosGroup/SPIRV-LLVM-Translator@daad382
The implementation is following https://github.com/KhronosGroup/SYCL-Shared/blob/master/proposals/sycl_generalization.md.
It is OpenCL centric, and a Level-Zero counterpart is coming here: #1723
An important "side-effect" is that plugins are initialized from these APIs and not only from get_platforms() in the current state.
Signed-off-by: Sergey V Maslov [email protected]