Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Disabling failing tests on Windows #785

Merged
bader merged 1 commit into from
Jan 30, 2022
Merged

[SYCL] Disabling failing tests on Windows #785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion SYCL/Basic/image/image_sample.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out
// RUN: %CPU_RUN_PLACEHOLDER %t.out
// RUN: %GPU_RUN_PLACEHOLDER %t.out
// UNSUPPORTED: cuda || hip
// Temporarily disable test on Windows due to regressions in GPU driver.
// UNSUPPORTED: cuda || hip, windows
Copy link

@vladimirlaz vladimirlaz Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it is unsupported?
I guess it should be XFAIL:level_zero

Copy link
Author

@alexbatashev alexbatashev Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XFAIL is a poor test disabling practice. When the test is fixed, it'll fire up in every test run.

Copy link

@vladimirlaz vladimirlaz Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is intended. Otherwise we may miss fix/unstable tets behavior.

Copy link

@kbobrovs kbobrovs Jan 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 1 for XFAIL. XFAIL shows a problem in implementation which must be fixed, UNSUPPORTED means the test is not meant to be run at all on unsupported config.

Copy link

@bader bader Jan 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comment clearly explains the motivation to disable test on Windows. I agree with Alex that using UNSUPPORTED to disable failing tests in llvm-test-suite is less disruptive for CI system than XFAIL.
As of today, it's not possible to make some commits to intel/llvm and do not break CI checks if we use XFAIL mark.


#include <CL/sycl.hpp>

Expand Down
3 changes: 2 additions & 1 deletion SYCL/Printf/double.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@
// The test is written using conversion specifiers table from cppreference [1]
// [1]: https://en.cppreference.com/w/cpp/io/c/fprintf
//
// UNSUPPORTED: hip_amd
// Temporarily disable test on Windows due to regressions in GPU driver.
// UNSUPPORTED: hip_amd, windows
//
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out
// RUN: %CPU_RUN_PLACEHOLDER %t.out %CPU_CHECK_PLACEHOLDER
Expand Down
2 changes: 2 additions & 0 deletions SYCL/Sampler/normalized-clampedge-linear-float.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
// RUN: %GPU_RUN_PLACEHOLDER %t.out
// RUN: %CPU_RUN_PLACEHOLDER %t.out
// XFAIL: cuda || hip
// Temporarily disable test on Windows due to regressions in GPU driver.
// UNSUPPORTED: windows

// CUDA works with image_channel_type::fp32, but not with any 8-bit per channel
// type (such as unorm_int8)
Expand Down
4 changes: 3 additions & 1 deletion SYCL/Sampler/normalized-clampedge-nearest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
// Missing __spirv_ImageWrite, __spirv_SampledImage,
// __spirv_ImageSampleExplicitLod on AMD
// XFAIL: hip_amd
// Temporarily disable test on Windows due to regressions in GPU driver.
// UNSUPPORTED: windows

/*
This file sets up an image, initializes it with data,
Expand Down Expand Up @@ -144,4 +146,4 @@ int main() {
}

return 0;
}
}
5 changes: 3 additions & 2 deletions SYCL/Sampler/unnormalized-clamp-nearest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// UNSUPPORTED: hip
// Temporarily disable test on Windows due to regressions in GPU driver.
// UNSUPPORTED: hip, windows
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out
// RUN: %HOST_RUN_PLACEHOLDER %t.out
// RUN: %CPU_RUN_PLACEHOLDER %t.out
Expand Down Expand Up @@ -117,4 +118,4 @@ int main() {
}

return 0;
}
}
5 changes: 3 additions & 2 deletions SYCL/Sampler/unnormalized-clampedge-linear-float.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// UNSUPPORTED: hip
// Temporarily disable test on Windows due to regressions in GPU driver.
// UNSUPPORTED: hip, windows
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out
// RUN: %HOST_RUN_PLACEHOLDER %t.out
// RUN: %GPU_RUN_PLACEHOLDER %t.out
Expand Down Expand Up @@ -153,4 +154,4 @@ int main() {
}

return 0;
}
}
5 changes: 3 additions & 2 deletions SYCL/Sampler/unnormalized-clampedge-nearest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// UNSUPPORTED: hip
// Temporarily disable test on Windows due to regressions in GPU driver.
// UNSUPPORTED: hip, windows
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out
// RUN: %HOST_RUN_PLACEHOLDER %t.out
// RUN: %CPU_RUN_PLACEHOLDER %t.out
Expand Down Expand Up @@ -123,4 +124,4 @@ int main() {
}

return 0;
}
}