[SYCL] Disabling failing tests on Windows #785
Conversation
| // RUN: %GPU_RUN_PLACEHOLDER %t.out | ||
| // UNSUPPORTED: cuda || hip | ||
| // Temporarily disable test on Windows due to regressions in GPU driver. | ||
| // UNSUPPORTED: cuda || hip, windows |
There was a problem hiding this comment.
Why it is unsupported?
I guess it should be XFAIL:level_zero
There was a problem hiding this comment.
XFAIL is a poor test disabling practice. When the test is fixed, it'll fire up in every test run.
There was a problem hiding this comment.
this is intended. Otherwise we may miss fix/unstable tets behavior.
There was a problem hiding this comment.
- 1 for XFAIL. XFAIL shows a problem in implementation which must be fixed, UNSUPPORTED means the test is not meant to be run at all on unsupported config.
There was a problem hiding this comment.
I think the comment clearly explains the motivation to disable test on Windows. I agree with Alex that using UNSUPPORTED to disable failing tests in llvm-test-suite is less disruptive for CI system than XFAIL.
As of today, it's not possible to make some commits to intel/llvm and do not break CI checks if we use XFAIL mark.
AlexeySachkov
left a comment
AlexeySachkov
left a comment
There was a problem hiding this comment.
Ok with Printf/double.cpp temporary disabling on Windows
|
@bader, review comments have not been addressed AFAICS - there is still |
It's better ask @alexbatashev. |
Test failures are caused by GPU driver regression.
5 participants
Test failures are caused by driver regression.