[BMG][SKIPLIST] Fix stale swiglu_opts indices in xe2 triton_kernels skiplist#6703
Merged
Conversation
…kiplist Upstream commit 8d4c6cd ([KERNELS] Fix tmem overflow for fp32 matmul, triton-lang/triton#9967), merged via PR #6660, added 1 new fp32 test case to _build_test_op_cases() in test_matmul.py before the swiglu section. This shifted all swiglu parametrize indices by +1, causing pytest-skip's --select-fail-on-missing to reject the stale IDs. Increment each swiglu_optsN by 1 (89→90, 90→91, 93→94, 94→95). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Test verifying changes resolve the issue: |
exolyr
requested review from
gshimansky,
januszjah,
kwasd,
quinnlp,
vlad-penkin and
whitneywhtsang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream commit 8d4c6cd merged via PR #6660, added 1 new fp32 test case to _build_test_op_cases() in test_matmul.py before the swiglu section. This shifted all swiglu parametrize indices by +1, causing pytest-skip's --select-fail-on-missing to reject the stale IDs.
Increment each swiglu_optsN by 1 (89→90, 90→91, 93→94, 94→95).