[WIP] Triton extensions research#6030
Closed
quinnlp wants to merge 7 commits into
Closed
Conversation
quinnlp
force-pushed
the
quinnlp/ext-plugin-research
branch
from
9ead8d2 to
a0e3f8b
Compare
quinnlp
force-pushed
the
quinnlp/ext-plugin-research
branch
from
384a038 to
bd2c152
Compare
This commit applies a patch from an open PR in the triton repo that implements the build support for the triton-ext repo. PR: triton-lang/triton#9146 Commit: f54029c01670023920399b1b61d55c567650a444
- Update the compile-triton.sh script to build intel-triton by introducing the --llvm-shared option that enables building with llvm shared libraries. - Update the find module for the SPIRVToLLVMTranslator subproject to patch the subproject's cmake configuration with a change that ensures it finds the LLVM config package used by the main project instead of falling back to the find module for LLVM, which always requires that static LLVM libraries are available.
quinnlp
force-pushed
the
quinnlp/ext-plugin-research
branch
from
bd2c152 to
9756567
Compare
Contributor
|
FYI @quinnlp, spirv translator is updated, you can rebase and remove the corresponding changes in this PR. |
Contributor
Author
|
@whitneywhtsang now that triton-lang/triton#9549 and triton-lang/triton#9550 are being worked on, I've applied them both on this branch (with appropriate fixes): #6203 and I've been able to get my extension working! So, the changes in this PR are no longer necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New contributor declaration
I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end testsFILL THIS IN.Select one of the following.
littests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)