Skip to content

Switch to C++20#4891

Closed
kwasd wants to merge 1 commit into
mainfrom
vmusin/fix/c++20
Closed

Switch to C++20#4891
kwasd wants to merge 1 commit into
mainfrom
vmusin/fix/c++20

Conversation

@kwasd
Copy link
Copy Markdown
Contributor

@kwasd kwasd commented Aug 12, 2025

possible fix for #4890

@etiotto etiotto requested a review from whitneywhtsang August 12, 2025 18:17
@kwasd
Copy link
Copy Markdown
Contributor Author

kwasd commented Aug 12, 2025

Any possible problems on upstreaming further changes since this diverges with upstream?

@kwasd kwasd requested review from pbchekin and vlad-penkin August 12, 2025 18:31
@kwasd
Copy link
Copy Markdown
Contributor Author

kwasd commented Aug 12, 2025

@etiotto

Can we simply change the std level to C++20 instead of changing the code ?

For me it seems like this is too early to switch.
As of now, PyTorch use C++17: https://github.com/pytorch/pytorch/blob/9903ca4f70bdc1653016256f5b4fd74fdfc609f8/CMakeLists.txt#L45

It seems like today #4889 is a better fix.

By Anatoly
#2833 (comment):

Do you know if upstream is opened to changing to C++20 compliant?

I don't know, it seems to me that there is a connection with PyTorch, which still uses c++17 standard. I suppose that as soon as it updates the standard, Triton will do the same.

@kwasd kwasd closed this Aug 12, 2025
@kwasd kwasd deleted the vmusin/fix/c++20 branch December 8, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants