Make Windows build C++17 compliant#2833
Merged
Merged
Conversation
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
…std:c++20' Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev
commented
Nov 26, 2024
| blockPointerStruct.getLoc(), blockPointerStruct, rewriter); | ||
| assert(elems.size() == 7 && | ||
| "unexpected number of values unpacked from a block pointer"); | ||
| BlockPointerValues values{ |
Contributor
Author
There was a problem hiding this comment.
This code was according to c++20 standard.
This reverts commit 462bbf9.
anmyachev
commented
Nov 26, 2024
| set(CMAKE_CXX_STANDARD 20) | ||
| set(CMAKE_C_FLAGS_TRITONRELBUILDWITHASSERTS "/Zi /RTC1 /bigobj /Zc:preprocessor") | ||
| set(CMAKE_CXX_FLAGS_TRITONRELBUILDWITHASSERTS "/Zi /RTC1 /bigobj /Zc:preprocessor") | ||
| set(CMAKE_C_FLAGS_TRITONRELBUILDWITHASSERTS "/Zi /RTC1 /bigobj /Zc:preprocessor /permissive-") |
Contributor
Author
There was a problem hiding this comment.
anmyachev
requested review from
gshimansky,
pbchekin and
whitneywhtsang
and removed request for
gshimansky
pbchekin
reviewed
Nov 26, 2024
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Contributor
whitneywhtsang
left a comment
whitneywhtsang
left a comment
There was a problem hiding this comment.
Do you know if upstream is opened to changing to C++20 compliant?
Contributor
Author
I don't know, it seems to me that there is a connection with PyTorch, which still uses |
Contributor
whitneywhtsang
left a comment
whitneywhtsang
left a comment
There was a problem hiding this comment.
Adding Victor as a reviewer to see if he has any other ideas, otherwise this change LGTM.
victor-eds
reviewed
Nov 27, 2024
|
LGTM but NIT. |
anmyachev
commented
Nov 27, 2024
Co-authored-by: Victor Perez <victor.perez@codeplay.com>
victor-eds
approved these changes
Nov 27, 2024
This was referenced Aug 12, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.