Skip to content

Remove LTS workaround #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etiotto merged 2 commits into from
Jul 10, 2024
Merged

Remove LTS workaround #1595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f590ca4
Remove LTS workaround
whitneywhtsang Jul 9, 2024
3748ab0
Merge branch 'llvm-target' into whitneywhtsang/lts_workaround
whitneywhtsang Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions third_party/intel/lib/TritonIntelGPUToLLVM/TargetInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,6 @@ bool TargetInfo::warpReduce(RewriterBase &rewriter, Location loc,
SmallVector<Value> &acc, triton::ReduceOp op,
unsigned numLaneToReduce,
unsigned interleave) const {
const bool isLTS =
op->getParentOfType<ModuleOp>()->hasAttr("triton_gpu.is_lts");
if (isLTS)
return false;
// No horizontal reduce required.
if (numLaneToReduce == 1)
return false;
Expand Down
4 changes: 1 addition & 3 deletions third_party/intel/lib/TritonIntelGPUTransforms/RemoveLayoutConversions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -978,13 +978,11 @@ void LayoutRematerialization::rewriteSlice(SetVector<Value> &slice,
SetVector<Operation *> opsToRewrite;
// Keep track of yield operands that need to be duplicated.
DenseMap<Operation *, SmallVector<int>> yieldOperandsMap;
bool isLTS =
convertOp->getParentOfType<ModuleOp>()->hasAttr("triton_gpu.is_lts");
for (Value v : slice) {
auto layoutIt = layout.find(v);
assert(layoutIt != layout.end());
// If we already have a remat value for this value, use it.
if (!isLTS && hasRematValue(v, layoutIt->second)) {
if (hasRematValue(v, layoutIt->second)) {
mapping.map(v, getRematValue(v, layoutIt->second));
continue;
}
Expand Down