Skip to content

Remove LTS workaround#1595

Merged
etiotto merged 2 commits intollvm-targetfrom
whitneywhtsang/lts_workaround
Jul 10, 2024
Merged

Remove LTS workaround#1595
etiotto merged 2 commits intollvm-targetfrom
whitneywhtsang/lts_workaround

Conversation

@whitneywhtsang
Copy link
Copy Markdown
Contributor

@whitneywhtsang whitneywhtsang commented Jul 10, 2024

The workarounds were added in #1275 and #1337.
All huggingface training float32 models pass with the LTS workaround removed: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/9865658421

Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
@whitneywhtsang whitneywhtsang requested a review from alexbaden July 10, 2024 00:26
@whitneywhtsang whitneywhtsang self-assigned this Jul 10, 2024
@whitneywhtsang
Copy link
Copy Markdown
Contributor Author

Huggingface AllenaiLongformerBase HF Train Float32 passes with the workaround removed: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/9864487997/job/27239506127

@whitneywhtsang whitneywhtsang linked an issue Jul 10, 2024 that may be closed by this pull request
@whitneywhtsang whitneywhtsang marked this pull request as ready for review July 10, 2024 02:17
@etiotto etiotto merged commit 03efe15 into llvm-target Jul 10, 2024
@etiotto etiotto deleted the whitneywhtsang/lts_workaround branch July 10, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AllenaiLongformerBase HF Train Float32 fails under LTS Driver

3 participants