Check if driver support DPAS and 2D block operations#1565
Merged
Conversation
whitneywhtsang
force-pushed
the
whitneywhtsang/dev_prop
branch
from
68fdec0 to
5bf94fa
Compare
Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
whitneywhtsang
force-pushed
the
whitneywhtsang/dev_prop
branch
from
5bf94fa to
e66c7c4
Compare
victor-eds
reviewed
Jul 5, 2024
victor-eds
left a comment
victor-eds
left a comment
There was a problem hiding this comment.
Nice improvement! Should the prefix be triton_intel_gpu instead of triton_gpu? Should we have the attribute name be queried from TritonIntelGPUDialect instead of being constants in the code?
leonling-ll
reviewed
Jul 5, 2024
Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
whitneywhtsang
force-pushed
the
whitneywhtsang/dev_prop
branch
from
87482c8 to
5db5c26
Compare
Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
Contributor
Author
Done. |
leonling-ll
reviewed
Jul 7, 2024
Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
whitneywhtsang
force-pushed
the
whitneywhtsang/dev_prop
branch
from
f047ef6 to
6cff5f6
Compare
victor-eds
reviewed
Jul 8, 2024
etiotto
reviewed
Jul 8, 2024
Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
whitneywhtsang
force-pushed
the
whitneywhtsang/dev_prop
branch
from
c0959c6 to
7aab3de
Compare
chengjunlu
approved these changes
Jul 9, 2024
victor-eds
approved these changes
Jul 9, 2024
etiotto
added a commit
that referenced
this pull request
Jul 9, 2024
whitneywhtsang
added a commit
that referenced
this pull request
Jul 11, 2024
Reland #1565. --------- Signed-off-by: Whitney Tsang <whitney.tsang@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module attributes
triton_gpu.support_sg_2d_blockandtriton_gpu.support_dpasare added to the module if the driver supports the corresponding OpenCL extension.This way is preferred instead of checking if a driver is LTS, since the OpenCL extension can also be unsupported for non-LTS driver, and checking driver version is error prone.