Skip to content

Conversation

@hj-johannes-lee
Copy link
Contributor

fixes #1604

@hj-johannes-lee
Copy link
Contributor Author

I added only to qat-initcontainer.
But if it is better to divide the "default_licences.docker" into two different pieces, or change one of the other "libraries", let me know. I did not see any reason to do so.

@tkatila
Copy link
Contributor

tkatila commented Dec 4, 2023

I did some grepping. Seems like intel-dlb-initcontainer, intel-idxd-config-initcontainer and intel-qat-initcontainer don't copy our LICENSE file. Could you update those as well?

@hj-johannes-lee
Copy link
Contributor Author

hj-johannes-lee commented Dec 12, 2023

I did some grepping. Seems like intel-dlb-initcontainer, intel-idxd-config-initcontainer and intel-qat-initcontainer don't copy our LICENSE file. Could you update those as well?

Hi, Tuomas! Sure, I can add them to this pr.

But, I am a bit confused about why you mention intel-qat-initcontainer again. Do you mean that we need to copy something else than the current change?
Isn't "our" LICENSE the file in the root directory of the repo?

@tkatila
Copy link
Contributor

tkatila commented Dec 12, 2023

Sure, I can add them to this pr.

👍

But, I am a bit confused about why you mention intel-qat-initcontainer again. Do you mean that we need to copy something else than the current change?

AFAIK, current change is fine for qat initcontainer. I was just grepping the project without your change.

Isn't "our" LICENSE the file in the root directory of the repo?

Yes, but we should have it also in the container images.

@hj-johannes-lee hj-johannes-lee changed the title add LICENSE to qat-initcontainer dlb, idxd, qat: install LICENSE to initcontainer Dec 14, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36b5bf5) 51.89% compared to head (ce344cf) 51.89%.

❗ Current head ce344cf differs from pull request most recent head ae9c713. Consider uploading reports for the commit ae9c713 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1607   +/-   ##
=======================================
  Coverage   51.89%   51.89%           
=======================================
  Files          42       42           
  Lines        4916     4916           
=======================================
  Hits         2551     2551           
  Misses       2215     2215           
  Partials      150      150           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mythi mythi merged commit e24fece into intel:main Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

qat-initcontainer does not have LICENSE installed in root/licenses dir

4 participants