-
Notifications
You must be signed in to change notification settings - Fork 212
dlb, idxd, qat: install LICENSE to initcontainer #1607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I added only to qat-initcontainer. |
|
I did some grepping. Seems like intel-dlb-initcontainer, intel-idxd-config-initcontainer and intel-qat-initcontainer don't copy our LICENSE file. Could you update those as well? |
Hi, Tuomas! Sure, I can add them to this pr. But, I am a bit confused about why you mention |
👍
AFAIK, current change is fine for qat initcontainer. I was just grepping the project without your change.
Yes, but we should have it also in the container images. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1607 +/- ##
=======================================
Coverage 51.89% 51.89%
=======================================
Files 42 42
Lines 4916 4916
=======================================
Hits 2551 2551
Misses 2215 2215
Partials 150 150 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Hyeongju Johannes Lee <[email protected]>
fixes #1604