This repository was archived by the owner on May 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
Initial windows CI that should build release from sources #433
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| name: Reusable build action on windows | ||
| on: | ||
| workflow_call: | ||
| inputs: | ||
| name: | ||
| type: string | ||
| default: cpu | ||
| options: | ||
| type: string | ||
| default: | ||
| cuda_compiler_version: | ||
| type: string | ||
|
|
||
|
|
||
| outputs: | ||
| cache-suffix: | ||
| value: ${{ jobs.build.outputs.cache-suffix }} | ||
|
|
||
| jobs: | ||
| build: | ||
| name: Conda - ${{ inputs.name }} | ||
| runs-on: windows-latest | ||
|
|
||
| outputs: | ||
| cache-suffix: ${{ env.DATE }} | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 | ||
|
|
||
| - name: Set env context | ||
| run: | | ||
| echo RUN_STAMP=${{ runner.os }}-${{ inputs.name }} >> $env:GITHUB_ENV | ||
| echo CONDA_ENV_PATH=$env:CONDA/envs/omnisci-dev >> $env:GITHUB_ENV | ||
| echo "DATE=$(date +'%Y%m%d')" >> $env:GITHUB_ENV | ||
| echo TMP=$env:TMP >> $env:GITHUB_ENV | ||
|
|
||
| - name: Get env | ||
| run: | | ||
| Get-ChildItem env: | ||
|
|
||
| - name: Get disk space | ||
| run: | | ||
| Get-PSDrive | ||
|
|
||
| - name: Restore Conda env cache | ||
| id: conda-cache | ||
| uses: actions/cache@v3 | ||
| with: | ||
| path: | | ||
| ${{ env.CONDA_ENV_PATH }} | ||
| key: ${{ env.RUN_STAMP }}-conda-${{ hashFiles('omniscidb/scripts/mapd-deps-conda-windows-env.yml') }}-${{ env.DATE }} | ||
| restore-keys: | | ||
| ${{ env.RUN_STAMP }}-conda-${{ hashFiles('omniscidb/scripts/mapd-deps-conda-windows-env.yml') }}- | ||
|
|
||
| - name: Update Conda env | ||
| if: steps.conda-cache.cache-hit != 'true' | ||
| run: | | ||
| & $env:CONDA\condabin\conda.bat update conda | ||
| & $env:CONDA\condabin\conda.bat env update -f omniscidb/scripts/mapd-deps-conda-windows-env.yml | ||
|
|
||
| - name: Restore Maven cache | ||
| uses: actions/cache@v3 | ||
| with: | ||
| path: | | ||
| ~/.m2 | ||
| key: maven-${{ hashFiles('**/pom.xml') }} | ||
| restore-keys: maven- | ||
|
|
||
| - name: Conda - ${{ inputs.name }} | ||
| run: | | ||
| & $env:CONDA\condabin\conda.bat info | ||
| & $env:CONDA\condabin\conda.bat list -n omnisci-dev | ||
| & $env:CONDA\condabin\conda.bat run --no-capture-output -n omnisci-dev omniscidb\scripts\conda\build.bat ${{ inputs.options }} | ||
| Compress-Archive -Path . -DestinationPath $env:TMP\build.zip | ||
|
|
||
| - name: Upload build and src files | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: ${{ env.RUN_STAMP }}-build | ||
| path: ${{ env.TMP }}/build.zip | ||
|
|
||
| - name: Upload logs | ||
| if: always() | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: ${{ env.RUN_STAMP }}-logs | ||
| path: | | ||
| build/*.log | ||
| build/CMakeCache.txt | ||
| build/CMakeFiles/*.log | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| cd %~dp0\..\..\.. | ||
|
|
||
| cmake -B build -S . %* | ||
| cmake --build build --config Release --parallel | ||
|
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does folly not work on windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose it works but there is no conda-forge build on windows
https://github.com/conda-forge/folly-feedstock/blob/main/recipe/meta.yaml#L19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided to skip it for now, which would use std lib atomics on Windows. The Arena allocator is a bigger issue we need to solve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Someone is trying to write windows build so maybe eventually they will add one
conda-forge/folly-feedstock#98